all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Juri Linkov <juri@linkov.net>
Cc: "Lars Ingebrigtsen" <larsi@gnus.org>,
	42708@debbugs.gnu.org, rms@gnu.org,
	"積丹尼 Dan Jacobson" <jidanni@jidanni.org>
Subject: bug#42708: Let users copy "*Char Help*" buffer
Date: Wed, 11 Nov 2020 11:41:04 -0800 (PST)	[thread overview]
Message-ID: <550f3cdd-8b71-457f-a903-84f43b04938d@default> (raw)
In-Reply-To: <87a6voz57f.fsf@mail.linkov.net>

> >> No other effect, cursor-in-echo-area was necessary when
> >> 'read-char-choice' relied on 'read-key'.
> >
> > Seriously?  You've not only introduced a new function,
> > `read-char-from-minibuffer', AND used it here and there
> > (everywhere?) in place of `read-char` and `read-key`,
> > but you've ALSO changed the behavior of `read-char-choice`,
> > so it too no longer reads a char in the longstanding,
> > useful way, which we can count to NOT use the minibuffer?
> 
> This is a false accusation.  I have NOT changed the behavior of
> `read-char-choice`,

It was actually a question, not an accusation, but yes, the
word order wasn't interrogative, unfortunately.  Instead of
"You're going to the store?", I should have asked it as
"Are you going to the store?"

Apologies, if you did not, in fact, change `read-char-choice'.
That answers the question in a way that reassures me.

My question was in response to your message where (I thought)
you described some changes ("clean-up") to `read-char-choice',
including (I thought) that it no longer uses `read-key', and
you then said:

  "what remains in 'read-char-choice' after this clean-up,
   is just a call to 'read-char-from-minibuffer'..."

If `read-char-choice' will not, in fact, be changed to use
`read-char-from-minibuffer' then that will be good, IMO.
I hope such a change does not occur; let me put it that way.

Again, apologies if I misunderstood, and for any heard
false accusations.

As you know, I'm not happy about uses of `read-char' etc.
having been replaced by `read-char-from-minibuffer'.  I
also wouldn't be happy about wholesale replacement of uses
of `read-char-choice' by `read-char-from-minibuffer'.
Maybe it makes sense to replace some such occurrences, but
it would be good to see some justification case by case.

But if `read-char-choice' can itself remain in the
`read-char', `read-event', `read-key', etc. camp, then at
least that will be good, IMO.  Thx.





  reply	other threads:[~2020-11-11 19:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 13:41 bug#42708: Let users copy "*Char Help*" buffer 積丹尼 Dan Jacobson
2020-08-04 23:42 ` Juri Linkov
2020-08-05  9:24   ` Lars Ingebrigtsen
2020-08-05 23:52     ` Juri Linkov
2020-08-06  7:12       ` Lars Ingebrigtsen
2020-10-13  2:59         ` Lars Ingebrigtsen
2020-10-13 15:27           ` Drew Adams
2020-11-03 18:57           ` Juri Linkov
2020-11-09 13:39             ` Lars Ingebrigtsen
2020-11-10 19:51               ` Juri Linkov
2020-11-10 20:26                 ` Drew Adams
2020-11-11  5:40                   ` Richard Stallman
2020-11-11  8:09                   ` Juri Linkov
2020-11-11 19:41                     ` Drew Adams [this message]
2020-11-11 20:07                       ` Juri Linkov
2020-11-11 21:24                         ` Drew Adams
2020-11-12  7:32                           ` Juri Linkov
2020-11-12 18:09                             ` Drew Adams
2020-11-11 10:28                 ` Lars Ingebrigtsen
2020-11-11 19:19                   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550f3cdd-8b71-457f-a903-84f43b04938d@default \
    --to=drew.adams@oracle.com \
    --cc=42708@debbugs.gnu.org \
    --cc=jidanni@jidanni.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.