From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Build segfaults when loading image.el Date: Mon, 23 Dec 2019 18:51:28 -0800 Organization: UCLA Computer Science Department Message-ID: <550d1942-f29c-4801-356d-a8c4b3b77ea4@cs.ucla.edu> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="89782"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 Cc: emacs-devel@gnu.org To: Dhruva Krishnamurthy Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 24 03:51:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ijaIP-000NEu-RC for ged-emacs-devel@m.gmane.org; Tue, 24 Dec 2019 03:51:41 +0100 Original-Received: from localhost ([::1]:35474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijaIO-0007ad-PH for ged-emacs-devel@m.gmane.org; Mon, 23 Dec 2019 21:51:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56786) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ijaIJ-0007aX-3x for emacs-devel@gnu.org; Mon, 23 Dec 2019 21:51:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ijaIG-0007nx-Q3 for emacs-devel@gnu.org; Mon, 23 Dec 2019 21:51:34 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55894) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ijaIG-0007jm-JS for emacs-devel@gnu.org; Mon, 23 Dec 2019 21:51:32 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 830311601B4; Mon, 23 Dec 2019 18:51:30 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id f8V4Nr2t9XTh; Mon, 23 Dec 2019 18:51:29 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 35E181601B6; Mon, 23 Dec 2019 18:51:29 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id O5Vih30WmgWQ; Mon, 23 Dec 2019 18:51:29 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 042FC1601B4; Mon, 23 Dec 2019 18:51:29 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243600 Archived-At: On 12/23/19 6:09 PM, Dhruva Krishnamurthy wrote: > I still feel the original patch calling into IsMagickWandInstantiated() was > more correct Not sure I follow, but anyway any change along those lines would be more experimental, whereas the emacs-27 branch is for bug-fixing and is maintained more conservatively. PS. I didn't notice the "!!IsMagickWandInstantiated();" part of your patch; if I had, I would have omitted it from the emacs-27 branch and would have said why.