From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#20154: 25.0.50; json-encode-string is too slow for large strings Date: Sun, 22 Mar 2015 01:36:55 +0200 Message-ID: <550E0097.9000500@yandex.ru> References: <86twxf68zk.fsf@yandex.ru> <83384zwxdx.fsf@gnu.org> <550C3218.4000903@yandex.ru> <831tkjww0y.fsf@gnu.org> <550C3AB9.7020403@yandex.ru> <83wq2bveq6.fsf@gnu.org> <550C491A.6000909@yandex.ru> <83siczvcss.fsf@gnu.org> <550C504A.10708@yandex.ru> <83r3sjva0q.fsf@gnu.org> <550C6A06.6040203@yandex.ru> <83fv8zv0b1.fsf@gnu.org> <550C9E7B.4060907@yandex.ru> <837fuavkn9.fsf@gnu.org> <550DDE25.1090000@yandex.ru> <87a8z6vvp8.fsf@violet.siamics.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1426981101 8318 80.91.229.3 (21 Mar 2015 23:38:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 21 Mar 2015 23:38:21 +0000 (UTC) To: 20154@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 22 00:38:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YZSy1-0000vw-63 for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Mar 2015 00:38:09 +0100 Original-Received: from localhost ([::1]:49344 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZSy0-0006he-IV for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Mar 2015 19:38:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZSxx-0006hZ-Tk for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 19:38:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZSxu-0006vz-NN for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 19:38:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZSxu-0006vr-IX for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 19:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YZSxu-0003wE-94 for bug-gnu-emacs@gnu.org; Sat, 21 Mar 2015 19:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Mar 2015 23:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20154-submit@debbugs.gnu.org id=B20154.142698102515073 (code B ref 20154); Sat, 21 Mar 2015 23:38:02 +0000 Original-Received: (at 20154) by debbugs.gnu.org; 21 Mar 2015 23:37:05 +0000 Original-Received: from localhost ([127.0.0.1]:60141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZSwz-0003v3-83 for submit@debbugs.gnu.org; Sat, 21 Mar 2015 19:37:05 -0400 Original-Received: from mail-wg0-f45.google.com ([74.125.82.45]:35482) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YZSwx-0003uZ-Fg for 20154@debbugs.gnu.org; Sat, 21 Mar 2015 19:37:03 -0400 Original-Received: by wgdm6 with SMTP id m6so117561371wgd.2 for <20154@debbugs.gnu.org>; Sat, 21 Mar 2015 16:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=vk68D52HyfT0cElfPL3LtZ7Dgq5wPkoJmLQ1k0s/9ro=; b=YpGZqpVxCG9gbIIbgYpBYp0BgaU5ikHbaoaU7cPrwUwU+FhsegFMHY764QhG2e7LFI RKsX21aOR7bVacwSVv14+OyiswoWsTfmhTuG50ouLcl1CMVJELMzJrbp2VmDG4d79iTi X/fZTsybQph1YXJCu3g9oYv4suZxEFZdHOrRJ95TCbd5XFit6urF/GPzvgbRPUAIG/ZH r4UebOHQGM/2DHJQo2MRtwuVN3KMrbVAMAgDa49Lm7i/q2rBrVK90uFf4BR97YEnlYq/ tr0qt6g9VQRbnfhdzCtmAKsrp5ViH7jq/rEEOFOEUN2LgPYEwfOBkjgdNso8jf+ZtvYw y3cQ== X-Received: by 10.194.57.206 with SMTP id k14mr175653690wjq.1.1426981017721; Sat, 21 Mar 2015 16:36:57 -0700 (PDT) Original-Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id kr5sm12584415wjc.1.2015.03.21.16.36.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Mar 2015 16:36:57 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: <87a8z6vvp8.fsf@violet.siamics.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100770 Archived-At: On 03/22/2015 12:20 AM, Ivan Shmakov wrote: > Perhaps a plain vector may fit there? Where? > FWIW, using replace-match in the loop seem to speed up the > routine by another few percents. Indeed, it seems so, counter to Eli's advice earlier. Just by a bit. Anyway, the small boost is nice to have, but the buffer-based implementation is actually worse than the current one on small strings (because of `with-temp-buffer'). So I don't think we can simply replace it. A fast `replace-regexp-in-string' implementation would make that possible. P.S. Please keep the discussion participants in Cc, even if you prefer not to receive the copy email.