From: Daniel Colascione <dancol@dancol.org>
To: Alan Mackenzie <acm@muc.de>, Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-24 d69e9f1: CC Mode: Stop Font Lock forcing fontification from BOL. Fixes debbugs#19669.
Date: Fri, 20 Mar 2015 09:34:52 -0700 [thread overview]
Message-ID: <550C4C2C.9060807@dancol.org> (raw)
In-Reply-To: <20150320163027.GB3493@acm.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]
On 03/20/2015 09:30 AM, Alan Mackenzie wrote:
> Hello, Stefan.
>
> On Thu, Mar 19, 2015 at 04:56:16PM -0400, Stefan Monnier wrote:
>>>> you can handle fontification from 1,3, or 4 but not from 2. You need to
>>>> refine the system you use to keep track of whether we're within
>>>> a `union' so that it knows that position 2 is also "within a union".
>
>>> Well, sort of. The problem I'm facing is that in Dima Kogan's bug
>>> #19669, the following construct appears:
>
>>> 1. enum xxx_xxxx_xxxxxxxxxx_x
>>> 2. {XXX_XXXXXX_XXXX_XXX,
>>> 3. XXX_XXXXXX_XXX_XXX,
>>> 4. XXXX_XXXXX_XXXX_XXX,
>
>>> Note that the brace on L2 is on the same line as the first XXX_....
>
>>> When the user types on line 4, 5, ... here, CC Mode sets the
>>> fontification region start to JUST AFTER THE { ON L2. It is essential
>>> that Font Lock doesn't change this.
>
>> There's your problem: your current setup needs the starting point to be
>> either before "union" or after the first open brace.
>> It breaks down if it's between the two. That's the problem you need to fix.
>
> Not really. CC Mode is quite capable of handling the Font Lock region
> starting at BOL2. The problem is, when that starting point needs to be
> after the brace on L2, Font Lock moves the starting point somewhere
> else, fouling up the font locking. This is proving surprisingly tough
> to fix.
I don't understand. Why shouldn't I be able to tell cc-mode to fontify
*arbitrary* regions and expect it to correctly apply highlighting to
these regions? It's the idea that the region "needs to be after brace"
that I find confusing. Shouldn't jit-lock have the right to expand the
region arbitrarily?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-20 16:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150201212213.17840.3710@vcs.savannah.gnu.org>
[not found] ` <E1YI1y9-0004eO-Re@vcs.savannah.gnu.org>
2015-02-02 18:50 ` [Emacs-diffs] emacs-24 d69e9f1: CC Mode: Stop Font Lock forcing fontification from BOL. Fixes debbugs#19669 Stefan Monnier
2015-02-02 19:27 ` Alan Mackenzie
2015-02-03 2:12 ` Stefan Monnier
2015-02-02 18:54 ` Stefan Monnier
2015-02-02 21:39 ` Alan Mackenzie
2015-02-03 2:26 ` Stefan Monnier
2015-02-07 12:27 ` Alan Mackenzie
2015-02-07 15:29 ` Stefan Monnier
2015-02-07 15:40 ` Alan Mackenzie
2015-03-16 23:53 ` Daniel Colascione
2015-03-18 12:08 ` Alan Mackenzie
2015-03-19 3:34 ` Daniel Colascione
2015-03-19 9:31 ` Alan Mackenzie
2015-03-19 13:49 ` Stefan Monnier
2015-03-19 20:37 ` Alan Mackenzie
2015-03-19 20:56 ` Stefan Monnier
2015-03-20 16:30 ` Alan Mackenzie
2015-03-20 16:34 ` Daniel Colascione [this message]
2015-03-20 17:29 ` Alan Mackenzie
2015-03-20 21:25 ` Daniel Colascione
2015-03-20 22:30 ` Alan Mackenzie
2015-03-20 18:05 ` Stefan Monnier
2015-03-20 21:12 ` Alan Mackenzie
2015-03-20 22:01 ` Stefan Monnier
2015-03-30 16:44 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C4C2C.9060807@dancol.org \
--to=dancol@dancol.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.