From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Boruch Baum Newsgroups: gmane.emacs.bugs Subject: bug#20148: 24.4: function `bookmark-get-bookmark' Date: Fri, 20 Mar 2015 07:04:01 -0400 Message-ID: <550BFEA1.8080100@gmx.com> References: <550BA52D.1080805@gmx.com> <1c3990cf-d1db-45e5-8b31-9055cdab20bd@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VmPDs3KPghbDSKcIL5EnIBjMxgn3hDq9b" X-Trace: ger.gmane.org 1426849526 31703 80.91.229.3 (20 Mar 2015 11:05:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Mar 2015 11:05:26 +0000 (UTC) To: Drew Adams , 20148@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 20 12:05:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYujp-0007ae-FV for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 12:05:13 +0100 Original-Received: from localhost ([::1]:43214 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYujo-0000fh-PR for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Mar 2015 07:05:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYujj-0000dw-PI for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 07:05:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYuje-0003Qj-Ox for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 07:05:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYuje-0003QX-LG for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 07:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YYuje-00019j-7N for bug-gnu-emacs@gnu.org; Fri, 20 Mar 2015 07:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Boruch Baum Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Mar 2015 11:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20148 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20148-submit@debbugs.gnu.org id=B20148.14268494894419 (code B ref 20148); Fri, 20 Mar 2015 11:05:02 +0000 Original-Received: (at 20148) by debbugs.gnu.org; 20 Mar 2015 11:04:49 +0000 Original-Received: from localhost ([127.0.0.1]:58840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYujR-00019D-81 for submit@debbugs.gnu.org; Fri, 20 Mar 2015 07:04:49 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:49543) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYujO-000190-Mr for 20148@debbugs.gnu.org; Fri, 20 Mar 2015 07:04:47 -0400 Original-Received: from [192.168.1.12] ([96.232.130.59]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0M9eHT-1Yfjxo0YqF-00Cx6Y; Fri, 20 Mar 2015 12:04:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 In-Reply-To: <1c3990cf-d1db-45e5-8b31-9055cdab20bd@default> OpenPGP: url=hkp://keys.gnupg.net X-Provags-ID: V03:K0:gqR8gcBDQmyngmPT/r8eapbwVfXfpKGClZp39YGIA7JkkNMpt/j esAKIroH8gpdKvTupzaleLpuwP/Sn0wMgDveuYcIVsa+auzdB8iS2/misnPFd5bAK/B4yWh xSZi9RaUmLJphdjtUKans7U5E73iJIR3KTJbI2lMJ18g/YY09fXiSJgSd+n13RECsYu6se4 8gTnETRd1uKCBvOlibHtg== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100689 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VmPDs3KPghbDSKcIL5EnIBjMxgn3hDq9b Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Drew. Apology for the inconvenience. On 03/20/2015 01:04 AM, Drew Adams wrote: >> Function `bookmark-get-bookmark' ... >> >> 1] tests for the existence of a bookmark by checking whether the input= >> string matches a cons cell. This casts a net much wider than desirable= , >> and might better be (assoc bookmark-name-or-record bookmark-alist). >=20 > See the actual code. You're right. You could have just said 'line 336, not 335'. >=20 >> 2] returns only a string value on error, without passing nil back to t= he >> calling function. >> >> My usage case is that I was scripting a function to find org-mode file= s >> in a directory tree, and add them to a bookmark list if they aren't >> already bookmarked according to my naming convention. Originally, I ha= d >> tried checking for the existence of a bookmark using a few of the >> bookmark.el functions, such as bookmark-get-bookmark, but that looked >> inconvenient because they returned string values on failure. >=20 > See the actual code. >=20 > The doc string neglects to mention the optional argument. It should > say something like this (taken from Bookmark+): >=20 > Non-nil optional arg NOERROR means return nil if BOOKMARK is not a > valid bookmark. If NOERROR is nil then raise an error in this case. Missed that also. --=20 hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0 --VmPDs3KPghbDSKcIL5EnIBjMxgn3hDq9b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVC/6hAAoJEDvrUfDmCx9LxPYP/jjR8aksMxhTNEtGOwPOeTtK qk10y9ZIlxndEJOL/zNOiyB4XRC0XRIoZE4dN2Pe8fE9aB2dRhwkR5lEjQDjRtsz 2zvOv3AECk8qm01Wo+9ypC/bjyX8KgZj5TFBP/Uice+sy+bvn0pYQ5xcmmrpgLIF P0n0AgrChNJW/q9CJVij3Cw9gFusxhcsg5pFXQVAnoq4Iy+8LliAzCtD2fAyuQNk 3RSF9tFMTH6QDLDPqz0SOaSrgg0F6sWf6/2AOM2wjDLtZPrEM4Id9NaBfCKhZLb9 f5eoUYbj5hbX8ZkcOkanUdNiKgFbqc/eE2TMPe5ZxK9xfVmzzZN9N2Of/7ov+GA2 zFwgOym45qZ6p4T6SwAm6BpwDfH+/GoK51Xmr216oJlIN0JHV7I8/HS7cMdkCTBU HVWHp+Dj/ZsnGD9J2pHCCqBfxquuZ66LxpP+hdqwKgSKNK/0HHcXq5oq+NyzLRPK G7jJW003OSCB+Yu7IWbO4xsb3+eG7Ta05+P6NyDQelMh5mYeEmwm9TzbY748lKbv R7zAEEMEUzGwSYYnQQmOjcZwaQcCQSXhlt3CcoHY7Ci5KYvkLZSm6VNkogzfBbSt L+TKXIUJwOJJjTxb2bGP7MDhNMeqNPze8nhJTgmYtSVYnx7vA12YOKaUzEumNdSg 31CgxT6nEqa45YfE/XRt =QahC -----END PGP SIGNATURE----- --VmPDs3KPghbDSKcIL5EnIBjMxgn3hDq9b--