Re: testcover: setf-method and treatment of `defcustom'

[Stefan Merten <smerten@oekonux.de>]

Hi Stefan!

Today Stefan Monnier wrote:
>>> Does one of the 2 patches work?
>> I'd need to compile and install an Emacs 24 version for this to try.
> 
> Actually, not just "Emacs 24" but "Emacs trunk" because it uses gv.el
> which is new on the trunk.

Sure.

>>> My 1st patch has the downside that it doesn't call testcover-after at all.
>>> The reason is that I don't know what VAL to set in IDX when we do
>>> things like (push VAL (testcover-after IDX PLACE)): should it be the
>>> value read before pushing VAL onto it, or the value set afterwards?
>> My cent: Before pushing VAL. AFAICS `testcover-after' needs to see
>> PLACE unmodified.
> 
> So for (setf (testcover-after IDX PLACE) VAL), we should first read the
> value of PLACE, pass it to testcover-after, and then modify PLACE to
> have value VAL?

This is my understanding.


						Grüße

						Stefan