From: Dmitry Gutov <dmitry@gutov.dev>
To: "João Távora" <joaotavora@gmail.com>
Cc: 72705@debbugs.gnu.org
Subject: bug#72705: 31.0.50; eglot--dumb-tryc Filters out too much
Date: Mon, 19 Aug 2024 14:39:13 +0300 [thread overview]
Message-ID: <54dacc71-4395-431f-abc4-c60dc070cb03@gutov.dev> (raw)
In-Reply-To: <CALDnm51f4J4S8sszjBTxF9cVWUWT1oEyX=1j+pOBWa833_=Nrg@mail.gmail.com>
On 19/08/2024 12:22, João Távora wrote:
> On Mon, Aug 19, 2024 at 2:52 AM Dmitry Gutov <dmitry@gutov.dev> wrote:
>
>> has more completions
>> (one can look at them by pressing TAB after "math.A")
>
> That's not relevant. LSP servers can make completely different
> decisions in each position. What's relevant is to look at the completion
> list returned in the "math.As" case (via the events buffer, for example).
True, but it's hard to look at completions for "math.As" using
completion-at-point because try-completion behaves this way.
You can also check out Company's completions popup for "math.As" - it
shows the extra ones.
>> Not sure what's the best fix, but the patch below seems to address both
>> problems in my limited testing. WDYT?
>
> I would be (pleasantly) surprised if your change doesn't break something
> else. I tried many many variations in the fairly recent past and each
> of them seemed to break something. Be wary of :exit-function
> which is where things like snippet conversion and edits happen.
> So I'd say this need more testing, especially with more servers.
Here's hoping.
> I also don't understand why the "string-prefix" is being used.
> The "dumb" in eglot--dumb-try should be taken to heart.
string-prefix-p is being used because 'try-completion' will ignore
non-prefix completions as if they weren't there. We need to make sure
that the proposed "probe" is indeed a prefix for all completions.
> See logs of commits:
> d376462c7183752bf44b9bd20bf5020fe7eaf75a
> 4dcbf61c1518dc53061707aeff8887517e050003
> a6ef458e3831001b0acad57cf8fa75b77a4aff3f
>
> You should also encode whatever decisions you make in
> tests in eglot-tests.el.
Thanks for the references, I'll dig in more.
Surprised to hear that exit-function can be affected.
next prev parent reply other threads:[~2024-08-19 11:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 1:51 bug#72705: 31.0.50; eglot--dumb-tryc Filters out too much Dmitry Gutov
2024-08-19 9:22 ` João Távora
2024-08-19 11:39 ` Dmitry Gutov [this message]
2024-08-19 12:59 ` João Távora
2024-08-20 2:08 ` Dmitry Gutov
2024-08-20 9:40 ` João Távora
2024-08-21 0:30 ` Dmitry Gutov
2024-08-21 16:52 ` João Távora
2024-08-22 0:41 ` Dmitry Gutov
2024-08-22 16:59 ` João Távora
2024-08-22 23:16 ` Dmitry Gutov
2024-08-23 10:23 ` João Távora
2024-08-25 2:49 ` Dmitry Gutov
2024-08-25 9:53 ` João Távora
2024-08-25 15:56 ` Dmitry Gutov
2024-08-25 23:40 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54dacc71-4395-431f-abc4-c60dc070cb03@gutov.dev \
--to=dmitry@gutov.dev \
--cc=72705@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.