From: Phil Sainty <psainty@orcon.net.nz>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 31357@debbugs.gnu.org,
bug-gnu-emacs
<bug-gnu-emacs-bounces+psainty=orcon.net.nz@gnu.org>
Subject: bug#31357: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 ?
Date: Fri, 04 May 2018 09:34:47 +1200 [thread overview]
Message-ID: <54c47e29d981f94a537aa9bdf0f37276@webmail.orcon.net.nz> (raw)
In-Reply-To: <87k1sksquk.fsf@gmx.de>
On 2018-05-04 03:26, Michael Albinus wrote:
> Phil Sainty <psainty@orcon.net.nz> writes:
>> This should surely be covered in NEWS under the "Incompatible Lisp
>> Changes in Emacs 26.1" section?
>
> `tramp-make-tramp-file-name' has never been documented as public
> function, it is intended for internal use. Granted, this should have
> been signalled better.
Given the function naming, a NEWS entry seems warranted to me.
I do think that there *should* be a public interface for manipulating
tramp file names. If these were never intended as such then perhaps
such functionality could be introduced...
> That's the way to go. You could use (funcall
> 'tramp-make-tramp-file-name ...)
> in order to make the byte compiler quiet.
Perfect.
> However, I wouldn't check for emacs-version. Tramp exist as separate
> package, and the recent Tramp 2.4 runs with all Emacs 24, 25, 26 and
> 27. You might check for tramp-version.
Thanks; I've gone with this:
(apply
#'tramp-make-tramp-file-name
(if (version< tramp-version "2.3")
(list method user host temp hop)
(list method user domain host port temp hop)))
The changes in 2.4 sound good too.
> (setf (tramp-file-name-host vec) "whatever")
Ah, I'd actually tried that in 25.2 but those are not generalized
variables in that version. I see that it works in 26.1 though,
so that's an excellent enhancement.
cheers,
-Phil
next prev parent reply other threads:[~2018-05-03 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 14:23 bug#31357: 26.1; tramp-make-tramp-file-name: incompatible lisp changes in 26.1 ? Phil Sainty
2018-05-03 15:26 ` Michael Albinus
2018-05-03 21:34 ` Phil Sainty [this message]
2018-05-04 7:44 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54c47e29d981f94a537aa9bdf0f37276@webmail.orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=31357@debbugs.gnu.org \
--cc=bug-gnu-emacs-bounces+psainty=orcon.net.nz@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.