From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#23377: 25.0.93; Completion is extremely slow for insert-char Date: Tue, 26 Apr 2016 08:49:39 -0700 Organization: UCLA Computer Science Department Message-ID: <54bd647f-6a22-471e-620b-6ff376e546bb@cs.ucla.edu> References: <2fd9a9b4-fb49-da6e-f13b-0fce4708159a@cs.ucla.edu> <34cb394c-1a2f-4fe5-8a2f-d26702487aef@default> <571EEA4A.3020105@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------19DCAEE03B62324CFF359FBE" X-Trace: ger.gmane.org 1461685830 22564 80.91.229.3 (26 Apr 2016 15:50:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Apr 2016 15:50:30 +0000 (UTC) Cc: "N. Jackson" , 23377@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 26 17:50:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1av5Fg-0004xL-Pl for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Apr 2016 17:50:17 +0200 Original-Received: from localhost ([::1]:38508 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av5Fg-0001Bw-8I for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Apr 2016 11:50:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av5FX-00013Y-W1 for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 11:50:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1av5FS-0005PZ-Bv for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 11:50:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av5FS-0005PU-8p for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 11:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1av5FS-0000uw-1u for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 11:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Apr 2016 15:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23377 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 23377-submit@debbugs.gnu.org id=B23377.14616857903501 (code B ref 23377); Tue, 26 Apr 2016 15:50:01 +0000 Original-Received: (at 23377) by debbugs.gnu.org; 26 Apr 2016 15:49:50 +0000 Original-Received: from localhost ([127.0.0.1]:48935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1av5FG-0000uO-8u for submit@debbugs.gnu.org; Tue, 26 Apr 2016 11:49:50 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:52047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1av5FE-0000u9-4w for 23377@debbugs.gnu.org; Tue, 26 Apr 2016 11:49:48 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 23486161260; Tue, 26 Apr 2016 08:49:41 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 2V4UgjUUUzLc; Tue, 26 Apr 2016 08:49:40 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 41749161266; Tue, 26 Apr 2016 08:49:40 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WcfXdcMRQw7r; Tue, 26 Apr 2016 08:49:40 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 23016161260; Tue, 26 Apr 2016 08:49:40 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116867 Archived-At: This is a multi-part message in MIME format. --------------19DCAEE03B62324CFF359FBE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 04/26/2016 04:51 AM, Stefan Monnier wrote: > It's not adding a feature. It's disabling a feature with an easy to use > switch to re-enable it. > Don't make it a defcustom, just a defvar. OK, thanks, that's easy. Proposed patch (to emacs-25) attached. On my platform the performance is pretty bad without this, even without listing all the characters. I particularly notice it when I run Emacs over X from my office to home, something that's normally quite tolerable. I had already noticed this performance problem, but hadn't gotten around to looking into it until N. Jackson's bug report made it clear I wasn't alone. In the long run there are some things we can do to improve things (e.g., not compute menu items until displayed, not display those ugly boxed and useless hexadecimal numbers, use a better menu that lets users choose characters by shape rather than just by name, etc.) that could let us turn annotation on by default, but that all needs to wait until after Emacs 25 comes out. --------------19DCAEE03B62324CFF359FBE Content-Type: application/x-patch; name="0001-insert-char-annotates-names-only-on-request.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-insert-char-annotates-names-only-on-request.patch" RnJvbSAyOWY5MmNiYWY2MzY3YzRlMWI0YmVkY2E1MGJjOWQ0MzRhM2FhODQyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDI2IEFwciAyMDE2IDA4OjM4OjM2IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gaW5zZXJ0LWNoYXIgYW5ub3RhdGVzIG5hbWVzIG9ubHkgb24gcmVxdWVzdAoKVGhpcyBm aXhlcyBhIG1ham9yIFVJIGVmZmljaWVuY3kgcHJvYmxlbSB3aXRoIEMteCA4IFJFVCAoQnVn IzIzMzc3KS4KU29sdXRpb24gc3VnZ2VzdGVkIGJ5IFN0ZWZhbiBNb25uaWVyIGluOiBodHRw Oi8vYnVncy5nbnUub3JnLzIzMzc3IzM2CiogbGlzcC9pbnRlcm5hdGlvbmFsL211bGUtY21k cy5lbCAodW5pY29kZS1uYW1lLWFubm90YXRpb24tc3R5bGUpOgpOZXcgdmFyLgoocmVhZC1j aGFyLWJ5LW5hbWUpOiBVc2UgaXQuCi0tLQogbGlzcC9pbnRlcm5hdGlvbmFsL211bGUtY21k cy5lbCB8IDE0ICsrKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2ludGVybmF0aW9uYWwv bXVsZS1jbWRzLmVsIGIvbGlzcC9pbnRlcm5hdGlvbmFsL211bGUtY21kcy5lbAppbmRleCBk YmYxMjI0Li44MGFjNGRlIDEwMDY0NAotLS0gYS9saXNwL2ludGVybmF0aW9uYWwvbXVsZS1j bWRzLmVsCisrKyBiL2xpc3AvaW50ZXJuYXRpb25hbC9tdWxlLWNtZHMuZWwKQEAgLTI5Nzgs NiArMjk3OCwxMiBAQCBtdWxlLS11Y3MtbmFtZXMtYW5ub3RhdGlvbgogICAobGV0ICgoY2hh ciAoYXNzb2MgbmFtZSB1Y3MtbmFtZXMpKSkKICAgICAod2hlbiBjaGFyIChmb3JtYXQgIiAo JWMpIiAoY2RyIGNoYXIpKSkpKQogCisoZGVmdmFyIHVuaWNvZGUtbmFtZS1hbm5vdGF0aW9u LXN0eWxlIG5pbAorICAiU3R5bGUgdG8gdXNlIHdoZW4gbGlzdGluZyBVbmljb2RlIGNoYXJh Y3RlciBuYW1lcy4KK0lmIG5vbi1uaWwsIGFsc28gbGlzdCB0aGUgY2hhcmFjdGVyIGl0c2Vs ZiwgbmV4dCB0byBpdHMgbmFtZS4KK1RoZSBgaW5zZXJ0LWNoYXInIGZ1bmN0aW9uIHVzZXMg dGhpcyBzdHlsZSB3aGVuIGNvbXBsZXRpbmcKK1VuaWNvZGUgbmFtZXMgaW50ZXJhY3RpdmVs eS4iKQorCiAoZGVmdW4gcmVhZC1jaGFyLWJ5LW5hbWUgKHByb21wdCkKICAgIlJlYWQgYSBj aGFyYWN0ZXIgYnkgaXRzIFVuaWNvZGUgbmFtZSBvciBoZXggbnVtYmVyIHN0cmluZy4KIERp c3BsYXkgUFJPTVBUIGFuZCByZWFkIGEgc3RyaW5nIHRoYXQgcmVwcmVzZW50cyBhIGNoYXJh Y3RlciBieSBpdHMKQEAgLTMwMDEsOSArMzAwNywxMSBAQCByZWFkLWNoYXItYnktbmFtZQog CSAgIHByb21wdAogCSAgIChsYW1iZGEgKHN0cmluZyBwcmVkIGFjdGlvbikKIAkgICAgIChp ZiAoZXEgYWN0aW9uICdtZXRhZGF0YSkKLQkJICcobWV0YWRhdGEKLQkJICAgKGFubm90YXRp b24tZnVuY3Rpb24gLiBtdWxlLS11Y3MtbmFtZXMtYW5ub3RhdGlvbikKLQkJICAgKGNhdGVn b3J5IC4gdW5pY29kZS1uYW1lKSkKKyAgICAgICAgICAgICAgICAgKGlmIHVuaWNvZGUtbmFt ZS1hbm5vdGF0aW9uLXN0eWxlCisgICAgICAgICAgICAgICAgICAgICAnKG1ldGFkYXRhCisg ICAgICAgICAgICAgICAgICAgICAgIChhbm5vdGF0aW9uLWZ1bmN0aW9uIC4gbXVsZS0tdWNz LW5hbWVzLWFubm90YXRpb24pCisgICAgICAgICAgICAgICAgICAgICAgIChjYXRlZ29yeSAu IHVuaWNvZGUtbmFtZSkpCisgICAgICAgICAgICAgICAgICAgJyhtZXRhZGF0YSAoY2F0ZWdv cnkgLiB1bmljb2RlLW5hbWUpKSkKIAkgICAgICAgKGNvbXBsZXRlLXdpdGgtYWN0aW9uIGFj dGlvbiAodWNzLW5hbWVzKSBzdHJpbmcgcHJlZCkpKSkpCiAJIChjaGFyCiAJICAoY29uZAot LSAKMi41LjUKCg== --------------19DCAEE03B62324CFF359FBE--