all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#20026: [PATCH] 24.4; regexp parse miss in ruby-mode
@ 2015-03-07  1:35 Nobuyoshi Nakada
  2015-03-08 19:00 ` Dmitry Gutov
  0 siblings, 1 reply; 2+ messages in thread
From: Nobuyoshi Nakada @ 2015-03-07  1:35 UTC (permalink / raw
  To: 20026

ruby-mode misses a regexp just after an open brace ('{') or a vertical
bar ('|').  As the result, `forward-sexp` and regexp highlighting do not
work expectedly (or as a ruby interpreter interprets).

ex.

  tap { /'/ }

This "/'/" should be parsed as an regexp matches a single quote, but the
first operator is parsed as a division operator and the succeeding
single quote is parsed as a beginning of a string.

Same for `{|x| /'/}`.


--- lisp/progmodes/ruby-mode.el	2014-07-06 05:02:55.000000000 +0900
+++ lisp/progmodes/ruby-mode.el	2015-03-06 21:09:46.000000000 +0900
@@ -1777,7 +1777,7 @@
   (defvar ruby-syntax-before-regexp-re
     (concat
      ;; Special tokens that can't be followed by a division operator.
-     "\\(^\\|[[=(,~;<>]"
+     "\\(^\\|[[{|=(,~;<>]"
      ;; Distinguish ternary operator tokens.
      ;; FIXME: They don't really have to be separated with spaces.
      "\\|[?:] "


In GNU Emacs 24.4.1 (x86_64-apple-darwin14.0.0, NS apple-appkit-1343.16)
 of 2014-12-24 on tenten-slave.macports.org
Windowing system distributor `Apple', version 10.3.1344
Configured using:
 `configure --prefix=/opt/local --with-ns --without-x --without-dbus
 CC=/usr/bin/clang 'CFLAGS=-pipe -Os -arch x86_64'
 'LDFLAGS=-L/opt/local/lib -Wl,-headerpad_max_install_names -arch
 x86_64' CPPFLAGS=-I/opt/local/include'

Important settings:
  locale-coding-system: utf-8-hfs

Major mode: Ruby





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#20026: [PATCH] 24.4; regexp parse miss in ruby-mode
  2015-03-07  1:35 bug#20026: [PATCH] 24.4; regexp parse miss in ruby-mode Nobuyoshi Nakada
@ 2015-03-08 19:00 ` Dmitry Gutov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Gutov @ 2015-03-08 19:00 UTC (permalink / raw
  To: Nobuyoshi Nakada, 20026-done

Version: 25.1

On 03/07/2015 03:35 AM, Nobuyoshi Nakada wrote:
> ruby-mode misses a regexp just after an open brace ('{') or a vertical
> bar ('|').  As the result, `forward-sexp` and regexp highlighting do not
> work expectedly (or as a ruby interpreter interprets).

Pushed to master. Thanks.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-08 19:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-07  1:35 bug#20026: [PATCH] 24.4; regexp parse miss in ruby-mode Nobuyoshi Nakada
2015-03-08 19:00 ` Dmitry Gutov

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.