From: Dmitry Gutov <dgutov@yandex.ru>
To: Jackson Hamilton <jackson@jacksonrayhamilton.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Requesting patch review
Date: Sun, 08 Mar 2015 19:55:15 +0200 [thread overview]
Message-ID: <54FC8D03.1060503@yandex.ru> (raw)
In-Reply-To: <CAGiE8AzsfKi6YH2FP247H1cZOpS2nyPVDTmB0tYu6U3AM5XLUQ@mail.gmail.com>
On 03/08/2015 04:09 AM, Jackson Hamilton wrote:
> New patch for js-mode. Adds a new indentation option. I would appreciate
> review before merging.
Thanks for the patch.
I can see two directions for it to be improved:
- Port the tests. I suppose test/indent/*.js would be a good place for
the examples. You can create js-???.js, set the new option's, value
using file local variables (in a comment, at the top or the bottom of
the file), and then the right indentation would be tested automatically.
Run a single file with 'make js.js.test'.
- Add the option for the user to always have this indentation, no matter
if there's a comma after the first item or not. js2-mode can do that
(here's the original feature request:
https://github.com/mooz/js2-mode/issues/3). I suppose it'd be best if
the new variable had a different name and 3 possible values (nil -
default, t - always, dynamic - check to see if there are several
declarations).
By the way, in general it's better to send patches to the bug tracker.
They can get lost in emacs-devel if nobody pays attention right away.
next prev parent reply other threads:[~2015-03-08 17:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 2:09 Requesting patch review Jackson Hamilton
2015-03-08 8:16 ` Thien-Thi Nguyen
2015-03-08 17:55 ` Dmitry Gutov [this message]
2015-03-08 22:01 ` Jackson Hamilton
2015-03-09 23:36 ` Dmitry Gutov
2015-03-10 1:34 ` Jackson Hamilton
2015-03-10 3:22 ` Stefan Monnier
2015-03-10 16:04 ` Dmitry Gutov
2015-03-10 23:39 ` Paul Eggert
2015-03-10 0:40 ` Running test/indent examples, Was: " Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FC8D03.1060503@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=jackson@jacksonrayhamilton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.