From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Sat, 28 Feb 2015 15:14:48 -0500 Message-ID: <54F221B8.4050909@cornell.edu> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> <83wq31syvm.fsf@gnu.org> <54F20C96.4020507@cornell.edu> <83vbilsvb5.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1425154526 642 80.91.229.3 (28 Feb 2015 20:15:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Feb 2015 20:15:26 +0000 (UTC) Cc: 19909@debbugs.gnu.org, rpluim@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 28 21:15:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YRnn7-0002DD-O4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Feb 2015 21:15:13 +0100 Original-Received: from localhost ([::1]:42293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRnn6-00043K-N8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Feb 2015 15:15:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRnn1-0003zO-Hs for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 15:15:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRnmw-000262-Em for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 15:15:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRnmw-00025W-CK for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 15:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YRnmv-0007Ri-Nh for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 15:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Feb 2015 20:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: rpluim@gmail.com, bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142515449728598 (code B ref -1); Sat, 28 Feb 2015 20:15:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 20:14:57 +0000 Original-Received: from localhost ([127.0.0.1]:60870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRnmq-0007RA-91 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 15:14:56 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:40581) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRnmo-0007Qw-AJ for submit@debbugs.gnu.org; Sat, 28 Feb 2015 15:14:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRnmf-00021a-A2 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 15:14:49 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:46159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRnmf-00021V-6j for submit@debbugs.gnu.org; Sat, 28 Feb 2015 15:14:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRnmd-0003xT-Uc for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 15:14:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRnmY-00020J-VA for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 15:14:43 -0500 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:42721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRnmY-00020F-Q2; Sat, 28 Feb 2015 15:14:38 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t1SKEbPN030381; Sat, 28 Feb 2015 15:14:37 -0500 Original-Received: from [192.168.1.3] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t1SKEaxV016966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 28 Feb 2015 15:14:36 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 In-Reply-To: <83vbilsvb5.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99915 Archived-At: On 2/28/2015 2:14 PM, Eli Zaretskii wrote: >> Date: Sat, 28 Feb 2015 13:44:38 -0500 >> From: Ken Brown >> CC: bug-gnu-emacs@gnu.org >> >>> No, I meant your reasons for specifying --with-file-notification=w32. >>> You could only bump into this issue if you specified it, AFAIU. >> >> Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909#36, I think >> he specified --with-file-notification=w32 because he wanted file >> notification and didn't know he could use gfile. > > Isn't gfile the default for Cygwin? Yes. (Of course, the builder has to have the appropriate glib development package installed, or else file notification won't actually be used.) >> I'm inclined to go ahead with the revised patch he submitted in the >> above URL. I'll commit it (with Robert as author and with the change >> marked as a "tiny change") if that's OK with you, Eli. > > If that's what Cygwin users want, fine with me. I personally don't care, but Robert requested it, and I don't see any harm in it. So I'll go ahead as soon as I hear back from him as to how he wants his name shown. >> 1. Shouldn't the name in the ChangeLog be "Robert Pluim" instead of >> "rpluim" to match all the other entries? > > I don't think it matters when there's no assignment on file. > >> 2. I tested making a git commit with >> >> --author="Robert Pluim (tiny change)" >> >> but git stripped away the "(tiny change)" part. What should I do to get >> "tiny change" into the git history? Maybe it's not so important now, >> because I can put it into the ChangeLog, but I'm thinking about the >> future, when ChangeLogs are automatically generated. > > The projects I know of use > > Copyright-paperwork-exempt: yes > > on a separate line in the log message. You will see that I already > used that in Emacs, at least once. Thanks. Ken