From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Sat, 28 Feb 2015 13:44:38 -0500 Message-ID: <54F20C96.4020507@cornell.edu> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> <83wq31syvm.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1425149125 15612 80.91.229.3 (28 Feb 2015 18:45:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Feb 2015 18:45:25 +0000 (UTC) Cc: 19909@debbugs.gnu.org To: Eli Zaretskii , Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 28 19:45:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YRmO1-0004gn-7Q for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Feb 2015 19:45:13 +0100 Original-Received: from localhost ([::1]:42106 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmO0-0004Rc-DR for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Feb 2015 13:45:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmNv-0004O8-MG for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 13:45:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRmNq-0001vM-NX for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 13:45:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmNq-0001v1-Kf for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 13:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YRmNp-0005JA-Lf for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 13:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Feb 2015 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142514908320353 (code B ref -1); Sat, 28 Feb 2015 18:45:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 18:44:43 +0000 Original-Received: from localhost ([127.0.0.1]:60837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRmNX-0005IC-Ag for submit@debbugs.gnu.org; Sat, 28 Feb 2015 13:44:43 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60154) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRmNV-0005I0-5z for submit@debbugs.gnu.org; Sat, 28 Feb 2015 13:44:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRmNO-0001oO-Pf for submit@debbugs.gnu.org; Sat, 28 Feb 2015 13:44:35 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:53143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmNO-0001oK-N3 for submit@debbugs.gnu.org; Sat, 28 Feb 2015 13:44:34 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmNN-0004L1-HW for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 13:44:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRmNI-0001nc-IK for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 13:44:33 -0500 Original-Received: from limerock04.mail.cornell.edu ([128.84.13.244]:34049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmNI-0001nY-De; Sat, 28 Feb 2015 13:44:28 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t1SIiQm7015752; Sat, 28 Feb 2015 13:44:26 -0500 Original-Received: from [192.168.1.3] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t1SIiPPT007791 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 28 Feb 2015 13:44:26 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 In-Reply-To: <83wq31syvm.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99909 Archived-At: On 2/28/2015 12:57 PM, Eli Zaretskii wrote: >> Date: Sat, 28 Feb 2015 17:56:28 +0100 >> From: Robert Pluim >> Cc: Ken Brown , bug-gnu-emacs@gnu.org >> >> Perhaps the OP could explain why he wanted that. >> >> If you're referring to me, my motivation was to prevent a compilation error for >> an incorrect configure combination. I believe you started us all down the path >> of trying to get w32 notifying to work. I have no problem with using glib. > > No, I meant your reasons for specifying --with-file-notification=w32. > You could only bump into this issue if you specified it, AFAIU. Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909#36, I think he specified --with-file-notification=w32 because he wanted file notification and didn't know he could use gfile. Robert, please correct me if I'm misinterpreting what you wrote. I'm inclined to go ahead with the revised patch he submitted in the above URL. I'll commit it (with Robert as author and with the change marked as a "tiny change") if that's OK with you, Eli. Two questions: 1. Shouldn't the name in the ChangeLog be "Robert Pluim" instead of "rpluim" to match all the other entries? 2. I tested making a git commit with --author="Robert Pluim (tiny change)" but git stripped away the "(tiny change)" part. What should I do to get "tiny change" into the git history? Maybe it's not so important now, because I can put it into the ChangeLog, but I'm thinking about the future, when ChangeLogs are automatically generated. Ken