all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>, Robert Pluim <rpluim@gmail.com>
Cc: 19909@debbugs.gnu.org
Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin
Date: Sat, 28 Feb 2015 13:44:38 -0500	[thread overview]
Message-ID: <54F20C96.4020507@cornell.edu> (raw)
In-Reply-To: <83wq31syvm.fsf@gnu.org>

On 2/28/2015 12:57 PM, Eli Zaretskii wrote:
>> Date: Sat, 28 Feb 2015 17:56:28 +0100
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Ken Brown <kbrown@cornell.edu>, bug-gnu-emacs@gnu.org
>>
>>      Perhaps the OP could explain why he wanted that.
>>
>> If you're referring to me, my motivation was to prevent a compilation error for
>> an incorrect configure combination. I believe you started us all down the path
>> of trying to get w32 notifying to work. I have no problem with using glib.
>
> No, I meant your reasons for specifying --with-file-notification=w32.
> You could only bump into this issue if you specified it, AFAIU.

Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909#36, I think 
he specified --with-file-notification=w32 because he wanted file 
notification and didn't know he could use gfile.  Robert, please correct 
me if I'm misinterpreting what you wrote.

I'm inclined to go ahead with the revised patch he submitted in the 
above URL.  I'll commit it (with Robert as author and with the change 
marked as a "tiny change") if that's OK with you, Eli.

Two questions:

1. Shouldn't the name in the ChangeLog be "Robert Pluim" instead of 
"rpluim" to match all the other entries?

2. I tested making a git commit with

   --author="Robert Pluim <rpluim@gmail.com>  (tiny change)"

but git stripped away the "(tiny change)" part.  What should I do to get 
"tiny change" into the git history?  Maybe it's not so important now, 
because I can put it into the ChangeLog, but I'm thinking about the 
future, when ChangeLogs are automatically generated.

Ken





  reply	other threads:[~2015-02-28 18:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20  9:47 bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Robert Pluim
2015-02-20 10:06 ` Eli Zaretskii
2015-02-20 10:19   ` Robert Pluim
2015-02-20 10:46     ` Eli Zaretskii
2015-02-20 14:16       ` Robert Pluim
2015-02-20 15:10         ` Eli Zaretskii
2015-02-20 15:46           ` Robert Pluim
2015-02-20 16:17             ` Eli Zaretskii
2015-02-20 16:44               ` Robert Pluim
2015-02-20 17:16                 ` Eli Zaretskii
2015-02-20 16:15           ` Ken Brown
2015-02-20 17:06             ` Robert Pluim
2015-02-20 17:18             ` Eli Zaretskii
2015-02-27 22:25               ` Ken Brown
2015-02-28  7:59                 ` Eli Zaretskii
2015-02-28 16:32                   ` Ken Brown
2015-02-28 16:41                     ` Eli Zaretskii
2015-02-28 16:53                       ` Robert Pluim
2015-02-28 16:56                       ` Robert Pluim
2015-02-28 17:57                         ` Eli Zaretskii
2015-02-28 18:44                           ` Ken Brown [this message]
2015-02-28 19:14                             ` Eli Zaretskii
2015-02-28 20:14                               ` Ken Brown
2015-03-02  9:35                                 ` Robert Pluim
2015-03-02 14:05                                   ` Ken Brown
2015-03-02 14:06 ` bug#19909: closed (Re: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin) GNU bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F20C96.4020507@cornell.edu \
    --to=kbrown@cornell.edu \
    --cc=19909@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.