From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#19962: 25.0.50; window-configuration-change-hook not running on trunk Date: Fri, 27 Feb 2015 20:57:28 +0100 Message-ID: <54F0CC28.9030909@gmx.at> References: <87fv9r6vuz.fsf@loki.jorgenschaefer.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1425067103 1056 80.91.229.3 (27 Feb 2015 19:58:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Feb 2015 19:58:23 +0000 (UTC) To: Jorgen Schaefer , 19962@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 27 20:58:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YRR34-0001kB-TE for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Feb 2015 20:58:11 +0100 Original-Received: from localhost ([::1]:38800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRR34-0000sL-7E for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Feb 2015 14:58:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRR30-0000ks-5K for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 14:58:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRR2w-0001vZ-MJ for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 14:58:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRR2w-0001vS-Js for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 14:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YRR2w-0003K6-65 for bug-gnu-emacs@gnu.org; Fri, 27 Feb 2015 14:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Feb 2015 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19962 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19962-submit@debbugs.gnu.org id=B19962.142506706712752 (code B ref 19962); Fri, 27 Feb 2015 19:58:02 +0000 Original-Received: (at 19962) by debbugs.gnu.org; 27 Feb 2015 19:57:47 +0000 Original-Received: from localhost ([127.0.0.1]:60230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRR2h-0003Jc-29 for submit@debbugs.gnu.org; Fri, 27 Feb 2015 14:57:47 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:53817) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRR2e-0003JO-2s for 19962@debbugs.gnu.org; Fri, 27 Feb 2015 14:57:44 -0500 Original-Received: from [178.189.200.198] ([178.189.200.198]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MQ2Tn-1YNsfJ0Vhj-005EaR; Fri, 27 Feb 2015 20:57:38 +0100 In-Reply-To: <87fv9r6vuz.fsf@loki.jorgenschaefer.de> X-Provags-ID: V03:K0:SlsEqFvMDZWMB2yqj74LOf0Z3Ae+D49ocrBEarS/tSXVlxYrqR1 lkE8W4CMYvTiirmRynaJWWcwVImobcP/oLHEF96/feD+BXVboCwcGsQHn/7oKi8xKJ7GXhW 4mckyUGQMf/iWxi1PzeNSy72MvpNlEiIbdvHbNCaDzwTk2kCc5RH8+La6ORFYFpO7xunlQM gRE0L5zM+o17lIxs/nvjQ== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99883 Archived-At: > With recent Emacs versions from trunk, it seems > `window-configuration-change-hook' is not run anymore. > > Reproduction: > > (setq window-configuration-change-hook > '((lambda () > (message "Change!")))) > > C-x 2 => does not show "Change!" > > In Emacs 24.4, this still happened. > > In GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu) > of 2015-02-21 on loki.jorgenschaefer.de > Repository revision: 9074a684990600abd9dfad0477c7cd1d2f339ed3 > System Description: Debian GNU/Linux 7.8 (wheezy) > > Same behavior in b2a590d4e3dc692a97c1b53e015b945d84b4b4c7 from > 2015-02-27. > > > Configured using: > `configure --without-x' Bad. Does the following patch fix it? diff --git a/src/window.c b/src/window.c index d59616d..efbe70f 100644 --- a/src/window.c +++ b/src/window.c @@ -3328,7 +3328,9 @@ run_window_configuration_change_hook (struct frame *f) XSETFRAME (frame, f); if (NILP (Vrun_hooks) +#ifdef HAVE_WINDOW_SYSTEM || !(f->can_x_set_window_size) +#endif || !(f->after_make_frame)) return; martin