From: Paul Eggert <eggert@cs.ucla.edu>
To: Wolfgang Jenkner <wjenkner@inode.at>
Cc: 19874@debbugs.gnu.org, Ashish SHUKLA <ashish.is@lostca.se>
Subject: bug#19874: 25.0.50; encode-time not working as expected
Date: Thu, 26 Feb 2015 22:31:41 -0800 [thread overview]
Message-ID: <54F00F4D.8010807@cs.ucla.edu> (raw)
In-Reply-To: <85mw405whp.fsf@iznogoud.viz>
Wolfgang Jenkner wrote:
> Thanks for the explanation! However, there's no indication that mktime
> is buggy (all tests pass when adjusting time_t_min, time_t_max), while
> localtime (and localtime_r) certainly is. Nevertheless, the configure
> test causes mktime to be replaced but not localtime_r, which is actually
> used in emacs. If I may say so this seems a bit like pulling the wrong
> tooth ;-)
I suppose we could make Gnulib smarter, so that it replaces some other function
if it finds a particular bug in mktime, a bug that can be chalked up to
localtime_r etc. However, the current approach is simpler to maintain and
shouldn't hurt anything. Ashish's problem seems not to be in mktime at all (nor
in its replacement).
>> It also appears to be the case that FreeBSD 10.1's implementation of
>> putenv is buggy, and that this is what is breaking Emacs's time code
>> (as Emacs uses putenv to modify the TZ environment variable), but we
>> haven't gotten to the bottom of that yet. I'll try to write a little
>> test program to narrow it down.
>
> But putenv is already replaced on my 10-STABLE system (and emacs trunk):
>
> $ nm src/emacs | grep putenv
> 00000000005b85a0 T rpl_putenv
> 0000000000527150 T xputenv
Yes, and that's because FreeBSD putenv is incompatible with GNU putenv; in GNU
systems, putenv ("xxx") is equivalent to unsetenv ("xxx") but FreeBSD doesn't
support this extension to POSIX. I don't know whether Emacs needs this
extension, but it shouldn't hurt to have it.
> Ah, and the OP's example actually seems to give the expected result here
> (my timezone is Europe/Vienna):
Yes. I can't reproduce the problem either. I finally got around to building a
VM running FreeBSD 10.1 amd64, and I cannot reproduce the bug, even when
/etc/localtime is a copy of /usr/share/zoneinfo/Asia/Kolkata and TZ is initially
unset. However, I am running it in a text window, not under Gtk3.
Perhaps Gtk3 is in some way interfering with Emacs's putenv substitute.
next prev parent reply other threads:[~2015-02-27 6:31 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-15 13:40 bug#19874: 25.0.50; encode-time not working as expected Ashish SHUKLA
2015-02-15 23:33 ` Ashish SHUKLA
2015-02-25 17:41 ` Paul Eggert
2015-02-26 0:24 ` Ashish SHUKLA
2015-02-26 8:15 ` Paul Eggert
2015-02-26 13:42 ` Wolfgang Jenkner
2015-02-26 17:36 ` Wolfgang Jenkner
2015-02-26 17:58 ` Paul Eggert
2015-02-26 16:03 ` Ashish SHUKLA
2015-02-26 6:51 ` Ashish SHUKLA
2015-02-26 8:39 ` Paul Eggert
2015-02-26 15:58 ` Ashish SHUKLA
2015-02-27 5:13 ` Paul Eggert
2015-02-26 19:00 ` Wolfgang Jenkner
2015-02-26 19:44 ` Ashish SHUKLA
2015-02-26 20:05 ` Wolfgang Jenkner
2015-02-26 21:47 ` Ashish SHUKLA
2015-02-27 0:16 ` Wolfgang Jenkner
2015-02-27 2:51 ` Wolfgang Jenkner
2015-02-27 4:59 ` Ashish SHUKLA
2015-02-27 6:38 ` Paul Eggert
2015-02-27 8:09 ` Paul Eggert
2015-02-27 8:49 ` Ashish SHUKLA
2015-02-27 6:31 ` Paul Eggert [this message]
2015-02-27 8:28 ` Ashish SHUKLA
2015-02-27 16:41 ` Paul Eggert
2015-02-27 17:33 ` Wolfgang Jenkner
2015-02-27 23:54 ` Paul Eggert
2015-02-28 14:10 ` Wolfgang Jenkner
2015-02-28 14:18 ` Wolfgang Jenkner
2015-02-28 19:43 ` Paul Eggert
2015-03-01 16:42 ` Wolfgang Jenkner
2015-03-01 18:28 ` Paul Eggert
2015-03-01 22:49 ` Wolfgang Jenkner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F00F4D.8010807@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=19874@debbugs.gnu.org \
--cc=ashish.is@lostca.se \
--cc=wjenkner@inode.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.