From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: "Jan D." <jan.h.d@swipnet.se>
Newsgroups: gmane.emacs.devel
Subject: Re: [Emacs-diffs] master 719fd93: Redo the whole window offsets and
	coordinate translation for X.
Date: Thu, 26 Feb 2015 16:02:26 +0100
Message-ID: <54EF3582.9080709@swipnet.se>
References: <20150225191654.16399.81439@vcs.savannah.gnu.org>	<E1YQhS2-0004HH-Ir@vcs.savannah.gnu.org>
	<jwvbnkgg1to.fsf-monnier+emacsdiffs@gnu.org>
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Trace: ger.gmane.org 1424962988 6252 80.91.229.3 (26 Feb 2015 15:03:08 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Thu, 26 Feb 2015 15:03:08 +0000 (UTC)
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 26 16:02:58 2015
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by plane.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1YQzxo-0005mv-PP
	for ged-emacs-devel@m.gmane.org; Thu, 26 Feb 2015 16:02:56 +0100
Original-Received: from localhost ([::1]:59484 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1YQzxn-0006op-S6
	for ged-emacs-devel@m.gmane.org; Thu, 26 Feb 2015 10:02:55 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51065)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.h.d@swipnet.se>) id 1YQzxX-0006lf-OE
	for emacs-devel@gnu.org; Thu, 26 Feb 2015 10:02:44 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.h.d@swipnet.se>) id 1YQzxS-0003Iu-MY
	for emacs-devel@gnu.org; Thu, 26 Feb 2015 10:02:39 -0500
Original-Received: from mailfe02.swip.net ([212.247.154.33]:46914 helo=swip.net)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.h.d@swipnet.se>) id 1YQzxS-0003I7-FU
	for emacs-devel@gnu.org; Thu, 26 Feb 2015 10:02:34 -0500
X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50
Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified)
	by mailfe02.swip.net (CommuniGate Pro SMTP 5.4.4)
	with ESMTPA id 577030388; Thu, 26 Feb 2015 16:02:29 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
	rv:31.0) Gecko/20100101 Thunderbird/31.5.0
In-Reply-To: <jwvbnkgg1to.fsf-monnier+emacsdiffs@gnu.org>
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 212.247.154.33
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:183515
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/183515>

Stefan Monnier skrev den 2015-02-26 15:56:
> Hi Jan,
>
>> --- a/src/xmenu.c
>> +++ b/src/xmenu.c
>> @@ -1211,13 +1211,25 @@ create_and_show_popup_menu (struct frame *f,
>> widget_value *first_wv,
>
> You missed the second definition of create_and_show_popup_menu in
> xmenu.c which still uses FRAME_OUTER_TO_INNER_DIFF_X.
>

Sloppy of me, I'm on it.

> [ Thinking out loud: We really should try and reduce code-duplication in
>    those files.  ]
>

Agreed

	Jan D.