From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#19826: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '. Date: Sun, 22 Feb 2015 22:04:49 -0800 Organization: UCLA Computer Science Department Message-ID: <54EAC301.4040806@cs.ucla.edu> References: <20150221205502.26624.18158@vcs.savannah.gnu.org> <54EA8A56.30404@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000209020208010104080505" X-Trace: ger.gmane.org 1424671524 16685 80.91.229.3 (23 Feb 2015 06:05:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Feb 2015 06:05:24 +0000 (UTC) Cc: 19826-done@debbugs.gnu.org To: bruce.connor.am@gmail.com, Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 23 07:05:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YPm8m-0003kl-3H for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Feb 2015 07:05:12 +0100 Original-Received: from localhost ([::1]:42153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPm8l-0000Ab-Ce for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Feb 2015 01:05:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPm8g-00006W-Im for bug-gnu-emacs@gnu.org; Mon, 23 Feb 2015 01:05:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPm8d-0001Uu-1w for bug-gnu-emacs@gnu.org; Mon, 23 Feb 2015 01:05:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59756) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPm8c-0001UL-SJ for bug-gnu-emacs@gnu.org; Mon, 23 Feb 2015 01:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YPm8c-0003to-F6 for bug-gnu-emacs@gnu.org; Mon, 23 Feb 2015 01:05:02 -0500 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Feb 2015 06:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 19826 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 19826@debbugs.gnu.org, eggert@cs.ucla.edu, mvoteiza@udel.edu Original-Received: via spool by 19826-done@debbugs.gnu.org id=D19826.142467149514967 (code D ref 19826); Mon, 23 Feb 2015 06:05:01 +0000 Original-Received: (at 19826-done) by debbugs.gnu.org; 23 Feb 2015 06:04:55 +0000 Original-Received: from localhost ([127.0.0.1]:50994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPm8V-0003tK-69 for submit@debbugs.gnu.org; Mon, 23 Feb 2015 01:04:55 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:38380) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YPm8S-0003tB-Gz for 19826-done@debbugs.gnu.org; Mon, 23 Feb 2015 01:04:53 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 9267939E8019; Sun, 22 Feb 2015 22:04:51 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IPuSnn7YhsoN; Sun, 22 Feb 2015 22:04:50 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 3415439E8018; Sun, 22 Feb 2015 22:04:50 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99724 Archived-At: This is a multi-part message in MIME format. --------------000209020208010104080505 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Artur Malabarba wrote: > The actual binding was supposed to be C-x C-;. The problem with bootstrap > surprises me, but I guess it must be something in the order that files are > loaded. It's because if you try to evaluate the string "\C-;", Emacs throws (error "Invalid modifier in string"). I installed the attached patch to use the keybinding that you wanted. This should fix the bug, so I'm closing the bug report. --------------000209020208010104080505 Content-Type: text/x-patch; name="0001-Fix-the-desired-binding-for-comment-line.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-the-desired-binding-for-comment-line.patch" >From f03d9e2d77771d10a61db329091dc6bc7f547bdf Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 22 Feb 2015 22:00:01 -0800 Subject: [PATCH] Fix the desired binding for comment-line * bindings.el (ctl-x-map): Use [?\C-\;] to get the desired binding. Fixes: bug#19826 --- lisp/ChangeLog | 6 ++++++ lisp/bindings.el | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 6352d77..c1fb869 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,9 @@ +2015-02-23 Paul Eggert + + Fix the desired binding for comment-line + * bindings.el (ctl-x-map): Use [?\C-\;] to get the desired binding. + Fixes: bug#19826 + 2015-02-23 Stefan Monnier * emacs-lisp/macroexp.el (macroexp-parse-body): Handle cl-declare diff --git a/lisp/bindings.el b/lisp/bindings.el index a1f0d98..b658914 100644 --- a/lisp/bindings.el +++ b/lisp/bindings.el @@ -1130,7 +1130,7 @@ if `inhibit-field-text-motion' is non-nil." (define-key esc-map "j" 'indent-new-comment-line) (define-key esc-map "\C-j" 'indent-new-comment-line) (define-key ctl-x-map ";" 'comment-set-column) -(define-key ctl-x-map "\M-;" 'comment-line) +(define-key ctl-x-map [?\C-\;] 'comment-line) (define-key ctl-x-map "f" 'set-fill-column) (define-key ctl-x-map "$" 'set-selective-display) -- 2.1.0 --------------000209020208010104080505--