From: Paul Eggert <eggert@cs.ucla.edu>
To: bruce.connor.am@gmail.com, Dmitry Gutov <dgutov@yandex.ru>
Cc: 19826-done@debbugs.gnu.org
Subject: bug#19826: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '.
Date: Sun, 22 Feb 2015 22:04:49 -0800 [thread overview]
Message-ID: <54EAC301.4040806@cs.ucla.edu> (raw)
In-Reply-To: <CAAdUY-L5=4TbuEGPTR0c2EHMv1Vr2jGngnj10n2ANOQR4WCCzQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
Artur Malabarba wrote:
> The actual binding was supposed to be C-x C-;. The problem with bootstrap
> surprises me, but I guess it must be something in the order that files are
> loaded.
It's because if you try to evaluate the string "\C-;", Emacs throws (error
"Invalid modifier in string"). I installed the attached patch to use the
keybinding that you wanted. This should fix the bug, so I'm closing the bug report.
[-- Attachment #2: 0001-Fix-the-desired-binding-for-comment-line.patch --]
[-- Type: text/x-patch, Size: 1387 bytes --]
From f03d9e2d77771d10a61db329091dc6bc7f547bdf Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 22 Feb 2015 22:00:01 -0800
Subject: [PATCH] Fix the desired binding for comment-line
* bindings.el (ctl-x-map): Use [?\C-\;] to get the desired binding.
Fixes: bug#19826
---
lisp/ChangeLog | 6 ++++++
lisp/bindings.el | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 6352d77..c1fb869 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,9 @@
+2015-02-23 Paul Eggert <eggert@cs.ucla.edu>
+
+ Fix the desired binding for comment-line
+ * bindings.el (ctl-x-map): Use [?\C-\;] to get the desired binding.
+ Fixes: bug#19826
+
2015-02-23 Stefan Monnier <monnier@iro.umontreal.ca>
* emacs-lisp/macroexp.el (macroexp-parse-body): Handle cl-declare
diff --git a/lisp/bindings.el b/lisp/bindings.el
index a1f0d98..b658914 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -1130,7 +1130,7 @@ if `inhibit-field-text-motion' is non-nil."
(define-key esc-map "j" 'indent-new-comment-line)
(define-key esc-map "\C-j" 'indent-new-comment-line)
(define-key ctl-x-map ";" 'comment-set-column)
-(define-key ctl-x-map "\M-;" 'comment-line)
+(define-key ctl-x-map [?\C-\;] 'comment-line)
(define-key ctl-x-map "f" 'set-fill-column)
(define-key ctl-x-map "$" 'set-selective-display)
--
2.1.0
next prev parent reply other threads:[~2015-02-23 6:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150221205502.26624.18158@vcs.savannah.gnu.org>
[not found] ` <E1YPH4o-0006wC-Cj@vcs.savannah.gnu.org>
2015-02-23 1:55 ` [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; ' Stefan Monnier
2015-02-23 2:03 ` Dmitry Gutov
2015-02-23 4:32 ` Stefan Monnier
2015-02-23 4:42 ` Artur Malabarba
2015-02-23 6:04 ` Paul Eggert [this message]
2015-02-23 7:32 ` bug#19826: " Artur Malabarba
2015-02-23 11:41 ` Andreas Schwab
2015-02-23 12:13 ` Nicolas Richard
2015-02-23 12:42 ` Artur Malabarba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EAC301.4040806@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=19826-done@debbugs.gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.