From: "Przemysław Wojnowski" <esperanto@cumego.com>
To: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel@gnu.org
Subject: Re: [PATCH] for review - making use of {EXEEXT} more uniform in makefiles.
Date: Fri, 20 Feb 2015 22:58:34 +0100 [thread overview]
Message-ID: <54E7AE0A.6090402@cumego.com> (raw)
In-Reply-To: <54E79986.4000909@cs.ucla.edu>
Is a ChangeLog entry needed when a patch touches only the tests?
W dniu 20.02.2015 o 21:31, Paul Eggert pisze:
> Michal Nazarewicz wrote:
>> Unless there are some concerns I’ll push the fixed patch on Monday.
>
> It's missing a ChangeLog entry and a commit message. Could you please construct
> a single combined patch (rather than two), and generate it with the command 'git
> format-patch', and attach it to a followup email? For an example of an email
> containing such a patch, please see:
>
> http://lists.gnu.org/archive/html/emacs-devel/2015-01/msg00909.html
>
next prev parent reply other threads:[~2015-02-20 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 1:20 [PATCH] for review - making use of {EXEEXT} more uniform in makefiles Pete Williamson
2015-02-18 2:01 ` Pete Williamson
2015-02-20 18:49 ` Pete Williamson
2015-02-20 20:10 ` Michal Nazarewicz
2015-02-20 20:31 ` Paul Eggert
2015-02-20 21:58 ` Przemysław Wojnowski [this message]
2015-02-20 22:27 ` Paul Eggert
2015-02-23 17:55 ` Pete Williamson
2015-02-23 18:17 ` Michal Nazarewicz
2015-02-23 18:20 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E7AE0A.6090402@cumego.com \
--to=esperanto@cumego.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.