Minibuffer completion does not work with ECB package?

Minibuffer completion does not work with ECB package?

[Angelo Graziosi]

It seems that minibuffer completion does not work properly if ECB 
package is installed (from MELPA with Emacs packages manager), and active.

For example, if I want to strip the trailing withe spaces (M-x 
delete-trailing-whitespace), I try

   M-x del<TAB>

In the minibuffer I get

Click on a completion to select it.
In this buffer, type RET to select the completion near point.

Possible completions are:
delete-backward-char 	delete-blank-lines
[...]


but at this point, if I click on 'delete-trailing-whitespace', I get

   Minibuffer is not active for completion


If I try to exit with C-G, it print 'Quit', but does not exit. In short, 
whatever I do I cannot exit minibuffer if not quitting Emacs.

In the above, if I change 'M-x del<TAB>' with

   M-x dele<TAB>

the completion works,

   M-x delete-

and with few other tabs I can complete the command.

I can reproduce this behavior with this minimal init.el file in ~/.emacs.d:

$ cat init.el
;;
;; ECB : Emacs Code browser setup
;;
(add-to-list 'load-path "~/.emacs.d/elpa/ecb-20140215.114")
(require 'ecb)

;; So that ECB is activated at Emacs startup
(setq ecb-auto-activate t)

;; This is suggested here:
;; http://www.patrickmin.com/linux/tip.php?name=emacs_ecb_startup
(setq ecb-tip-of-the-day nil)
(custom-set-variables '(ecb-options-version "2.40"))

Maybe the issue is in ECB, so I flagged this for completeness. If you 
think it regards Emacs directly (master), I will open a bug report, if 
needed.


TIA,
  Angelo.

Re: Minibuffer completion does not work with ECB package?

[Stefan Monnier]

> Maybe the issue is in ECB, so I flagged this for completeness. If you think
> it regards Emacs directly (master), I will open a bug report, if needed.

Even if the problem is ultimately considered to be on ECB's side,
I think it's worth opening a bug report for it, here.


        Stefan

bug#19848: Minibuffer completion does not work with ECB package?

[Angelo Graziosi]

(Following Stefan's suggestion: 
http://lists.gnu.org/archive/html/emacs-devel/2015-02/msg00790.html)

It seems that minibuffer completion does not work properly if ECB
package is installed (from MELPA, with : Options | Manage Emacs 
Packages), and active.

For example, if I want to strip the trailing withe spaces (M-x
delete-trailing-whitespace), I try

   M-x del<TAB>

In the minibuffer I get

Click on a completion to select it.
In this buffer, type RET to select the completion near point.

Possible completions are:
delete-backward-char 	delete-blank-lines
[...]


but at this point, if I click on 'delete-trailing-whitespace', I get

   Minibuffer is not active for completion


If I try to exit with C-G, it print 'Quit', but does not exit. In short,
whatever I do I cannot exit minibuffer if not quitting Emacs.

In the above, if I change 'M-x del<TAB>' with

   M-x dele<TAB>

the completion works,

   M-x delete-

and with few other tabs I can complete the command.

I can reproduce this behavior with this minimal init.el file in ~/.emacs.d:

$ cat init.el
;;
;; ECB : Emacs Code browser setup
;;
(add-to-list 'load-path "~/.emacs.d/elpa/ecb-20140215.114")
(require 'ecb)

;; So that ECB is activated at Emacs startup
(setq ecb-auto-activate t)

;; This is suggested here:
;; http://www.patrickmin.com/linux/tip.php?name=emacs_ecb_startup
(setq ecb-tip-of-the-day nil)
(custom-set-variables '(ecb-options-version "2.40"))

Maybe the issue is in ECB, so I flagged this just for completeness.


TIA,
  Angelo.

bug#19848: Minibuffer completion does not work with ECB package?

[Thorsten Bonow]

> It seems that minibuffer completion does not work properly if ECB
> package is installed (from MELPA, with : Options | Manage Emacs 
> Packages), and active.
 
> For example, if I want to strip the trailing withe spaces (M-x
> delete-trailing-whitespace), I try
 
>   M-x del<TAB>
 
> In the minibuffer I get
 
> Click on a completion to select it.
> In this buffer, type RET to select the completion near point.
 
> Possible completions are:
> delete-backward-char 	delete-blank-lines
> [...]
  
> but at this point, if I click on 'delete-trailing-whitespace', I get
 
>   Minibuffer is not active for completion
 
> If I try to exit with C-G, it print 'Quit', but does not exit. In short,
> whatever I do I cannot exit minibuffer if not quitting Emacs.

Hi,

I don't think it's an Emacs bug. I think ECB chokes on the Emacs 25
version of `minibuffer-completion-help' from "minibuffer.el".

Version 25 of `minibuffer-completion-help' now calls
`display-buffer-at-bottom' which appears not to be adapted to the ECB
layout. (ECB divides its frame into special ECB windows on the left or
right side of the frame and one main "edit-area". By advising the
window functions like `display-buffer', the ECB layout is left
undisturbed; window functions only act on the "edit-area". Since
`display-buffer-at-bottom' is not advised, this now fails with Emacs
25.)

As a workaround till this is fixed in ECB I wrote an advice for
`display-buffer-at-bottom', which overrides this defun in the ECB
frame and calls 'display-buffer-use-some-window' instead. A call to
`display-buffer-use-some-window' in other frames will call the
unmodified defun. The Completion buffer takes up the whole
"edit-area", but selecting a completion works for me now.

Toto

(defun display-buffer-at-bottom--display-buffer-at-bottom-around (orig-fun &rest args)
  "Bugfix for ECB: cannot use `display-buffer-at-bottom', call
`display-buffer-use-some-window' instead in ECB frame."
  (if (and ecb-minor-mode (equal (selected-frame) ecb-frame))
      (apply 'display-buffer-use-some-window args)
    (apply orig-fun args)))
(advice-add 'display-buffer-at-bottom :around #'display-buffer-at-bottom--display-buffer-at-bottom-around)

bug#19848: Minibuffer completion does not work with ECB package?

[Stefan Kangas]

Thorsten Bonow <thorsten.bonow@withouthat.org> writes:

>> It seems that minibuffer completion does not work properly if ECB
>> package is installed (from MELPA, with : Options | Manage Emacs 
>> Packages), and active.
>  
>> For example, if I want to strip the trailing withe spaces (M-x
>> delete-trailing-whitespace), I try
>  
>>   M-x del<TAB>
>  
>> In the minibuffer I get
>  
>> Click on a completion to select it.
>> In this buffer, type RET to select the completion near point.
>  
>> Possible completions are:
>> delete-backward-char 	delete-blank-lines
>> [...]
>   
>> but at this point, if I click on 'delete-trailing-whitespace', I get
>  
>>   Minibuffer is not active for completion
>  
>> If I try to exit with C-G, it print 'Quit', but does not exit. In short,
>> whatever I do I cannot exit minibuffer if not quitting Emacs.
>
> Hi,
>
> I don't think it's an Emacs bug. I think ECB chokes on the Emacs 25
> version of `minibuffer-completion-help' from "minibuffer.el".

The last message here suggests that this is not an Emacs bugs.  Does
anyone disagree with that?

Best regards,
Stefan Kangas

bug#19848: Minibuffer completion does not work with ECB package?

[Stefan Kangas]

Stefan Kangas <stefan@marxist.se> writes:

>> I don't think it's an Emacs bug. I think ECB chokes on the Emacs 25
>> version of `minibuffer-completion-help' from "minibuffer.el".
>
> The last message here suggests that this is not an Emacs bug.  Does
> anyone disagree with that?

More information was requested, but none was given within 4 weeks, so
I'm closing this bug.  If this is still an issue, please reply to this
email (use "Reply to all" in your email client) and we can reopen the
bug report.

Best regards,
Stefan Kangas

bug#19848: Minibuffer completion does not work with ECB package?

[Stefan Kangas]

Stefan Kangas <stefan@marxist.se> writes:

> Stefan Kangas <stefan@marxist.se> writes:
>
>>> I don't think it's an Emacs bug. I think ECB chokes on the Emacs 25
>>> version of `minibuffer-completion-help' from "minibuffer.el".
>>
>> The last message here suggests that this is not an Emacs bug.  Does
>> anyone disagree with that?
>
> More information was requested, but none was given within 4 weeks, so
> I'm closing this bug.  If this is still an issue, please reply to this
> email (use "Reply to all" in your email client) and we can reopen the
> bug report.

I missed to actually close this bug.  Closing it now.

Best regards,
Stefan Kangas

bug#19848: Minibuffer completion does not work with ECB package?

[Stefan Kangas]

Stefan Kangas <stefan@marxist.se> writes:

> Stefan Kangas <stefan@marxist.se> writes:
>
>>> I don't think it's an Emacs bug. I think ECB chokes on the Emacs 25
>>> version of `minibuffer-completion-help' from "minibuffer.el".
>>
>> The last message here suggests that this is not an Emacs bug.  Does
>> anyone disagree with that?
>
> More information was requested, but none was given within 4 weeks, so
> I'm closing this bug.  If this is still an issue, please reply to this
> email (use "Reply to all" in your email client) and we can reopen the
> bug report.

It seems this was left open for some reason; closing now.

Best regards,
Stefan Kangas