From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Date: Mon, 09 Feb 2015 14:20:25 -0800 Organization: UCLA Computer Science Department Message-ID: <54D932A9.1020004@cs.ucla.edu> References: <20150201003025.18138.95966@vcs.savannah.gnu.org> <54CDC38C.9080701@yandex.ru> <54CE05A0.2090701@cs.ucla.edu> <54D15CF5.3020809@cs.ucla.edu> <54D2BB6E.1040704@cs.ucla.edu> <54D90EE4.1000808@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1423520461 32716 80.91.229.3 (9 Feb 2015 22:21:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Feb 2015 22:21:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: joakim@verona.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 09 23:20:57 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YKwhL-0006DD-2O for ged-emacs-devel@m.gmane.org; Mon, 09 Feb 2015 23:20:55 +0100 Original-Received: from localhost ([::1]:35470 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKwhK-0008Js-Ft for ged-emacs-devel@m.gmane.org; Mon, 09 Feb 2015 17:20:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKwgy-0008It-Bs for emacs-devel@gnu.org; Mon, 09 Feb 2015 17:20:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKwgu-0007nL-9b for emacs-devel@gnu.org; Mon, 09 Feb 2015 17:20:32 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:36701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKwgu-0007nH-33 for emacs-devel@gnu.org; Mon, 09 Feb 2015 17:20:28 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 3EF30A60013; Mon, 9 Feb 2015 14:20:27 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zxiJjQZGpPUw; Mon, 9 Feb 2015 14:20:26 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E4FEAA60012; Mon, 9 Feb 2015 14:20:25 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182756 Archived-At: On 02/09/2015 12:24 PM, joakim@verona.se wrote: > My concern was that I have made no changees AFAIK to coding.c. So how > did it wind up in the patch you provided? I don't recall, but let's not worry about it. > >>> >>And these: >>> >>- next_element_from_stretch >>> >>+ next_element_from_stretch, >>> >> #ifdef HAVE_XWIDGETS >>> >>- ,next_element_from_xwidget >>> >>+ next_element_from_xwidget, >>> >> >>> >>is it really correct to move the coma out of the ifdef? >> > >> >Yes, in C99, which Emacs is now assuming. > It feels weird, but well okay then. And its really considered better > form? > I prefer it, because it lets one put #if/#endif brackets around any enum value without worrying about whether the value is listed first or last or in the middle. The style with leading "," is less consistent, in that it cannot be used with the first enum value.