From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#19619: 25.0.50; Fullheight frames in daemonized emacsen are wrong width Date: Mon, 09 Feb 2015 19:41:54 +0100 Message-ID: <54D8FF72.1040107@gmx.at> References: <54B9508D.8040609@gmx.at> <54D666D9.2020409@gmx.at> <87r3u1hrs2.fsf@md5i.com> <87h9uww3iu.fsf@gmx.net> <54D87E67.7050902@gmx.at> <874mqv1d9p.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1423508060 20727 80.91.229.3 (9 Feb 2015 18:54:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Feb 2015 18:54:20 +0000 (UTC) Cc: Michael Welsh Duggan , 19619@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 09 19:54:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YKtTO-0002O7-GC for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Feb 2015 19:54:18 +0100 Original-Received: from localhost ([::1]:34630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKtTO-0005qQ-4A for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Feb 2015 13:54:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKtIY-0003ns-Uy for bug-gnu-emacs@gnu.org; Mon, 09 Feb 2015 13:43:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKtIU-0001I4-Of for bug-gnu-emacs@gnu.org; Mon, 09 Feb 2015 13:43:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47301) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKtIU-0001Hx-IV for bug-gnu-emacs@gnu.org; Mon, 09 Feb 2015 13:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YKtIU-0003DL-CJ for bug-gnu-emacs@gnu.org; Mon, 09 Feb 2015 13:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Feb 2015 18:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19619-submit@debbugs.gnu.org id=B19619.142350733312272 (code B ref 19619); Mon, 09 Feb 2015 18:43:02 +0000 Original-Received: (at 19619) by debbugs.gnu.org; 9 Feb 2015 18:42:13 +0000 Original-Received: from localhost ([127.0.0.1]:38538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YKtHg-0003Bs-HB for submit@debbugs.gnu.org; Mon, 09 Feb 2015 13:42:12 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:63088) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YKtHe-0003Be-RI for 19619@debbugs.gnu.org; Mon, 09 Feb 2015 13:42:11 -0500 Original-Received: from [93.82.72.172] ([93.82.72.172]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MCggg-1YUCff2H3q-009OZ1; Mon, 09 Feb 2015 19:41:57 +0100 In-Reply-To: <874mqv1d9p.fsf@gmx.net> X-Provags-ID: V03:K0:ffqzMTa0cfDFRgMm+QQ+xbfHBBaxjU4ln3Wl+50/llD+9IhZ0d4 O6cdG6Q9NIvum2zROfrZOdeXipo7hDF20kBXA/tTjUj5y43pp14GMqx13PPgX4quNirwZgt YzzYUCNyKXI8WVYCm6qy2nS3qWXiN/pcdzrwozW2z4YYi/l567XTQnzR+JEt4tw+UqGC6e4 AdG7x3/NroeinRgBkq5Lw== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99220 Archived-At: > It does not happen with my latest build from the emacs-24 branch. (That > does not use a toolkit scroll bar, unlike my builds from master, though I > guess that isn't relevant here.) I think so too. The problem is the toolbar which gets resized _after_ the frame was made fullheight and before my last patch this (i.e., being fullheight) inhibited changing the frame's width as well. For example, if you had set the text width to 80 columns and enlarged the tool bar by say 4 columns that would have consumed 4 columns from the text and not enlarged the combined width of frame plus toolbar by 4 columns. That's what Michael detected and what I tried to fix lately. In fact, the problem was introduced by an earlier fix for the orthogonal problem where I tried to keep a frame fullheight/-width when changing the size of the toolbar on the side of the largest extension. So you should not see it on Emacs 24.4/5. >> And what happens with a fullwidth frame and the toolbar orthogonally to >> where it is now? > > Do you mean using the parameter (fullscreen . fullboth) and tool bar on > the left? I meant (fullscreen . fullwidth) and the tool bar on top. But that's irrelevant wrt to how many characters fit on a line, so drop it. > If so, the result is the same in master with and without you > recent patch: there's a bit of space between the last character and the > right fringe, but less than one column's worth. Probably because a fullboth frame's text width is not a multiple of the character width. What does evaluating (window--dump-frame) give on that frame? The result is in a buffer called *window-frame-dump*. If the second value I marked below is not the product of the first and third value I marked you should see that. frame pixel: 1680 x 984 cols/lines: 210 x 60 units: 8 x 16 ^ frame text pixel: 1648 x 968 cols/lines: 206 x 60 ^^^^ ^^^ tool: 0 scroll: 16/16 fringe: 16 border: 0 right: 6 bottom: 6 > Although, with your patch, I no longer observe the problem, in case you > want to do some ex post facto forensics, below is the minimal recipe I > came up with to show the problem. Do emacs -Q in a build from master > without your patch, evaluate the code and then type `M-x srb-test'. I can see it with that recipe. Thanks, martin