bug#19619: 25.0.50; Fullheight frames in daemonized emacsen are wrong width

[martin rudalics <rudalics@gmx.at>]

 > It does not happen with my latest build from the emacs-24 branch.  (That
 > does not use a toolkit scroll bar, unlike my builds from master, though I
 > guess that isn't relevant here.)

I think so too.  The problem is the toolbar which gets resized _after_
the frame was made fullheight and before my last patch this (i.e., being
fullheight) inhibited changing the frame's width as well.  For example,
if you had set the text width to 80 columns and enlarged the tool bar by
say 4 columns that would have consumed 4 columns from the text and not
enlarged the combined width of frame plus toolbar by 4 columns.  That's
what Michael detected and what I tried to fix lately.

In fact, the problem was introduced by an earlier fix for the orthogonal
problem where I tried to keep a frame fullheight/-width when changing
the size of the toolbar on the side of the largest extension.  So you
should not see it on Emacs 24.4/5.

 >> And what happens with a fullwidth frame and the toolbar orthogonally to
 >> where it is now?
 >
 > Do you mean using the parameter (fullscreen . fullboth) and tool bar on
 > the left?

I meant (fullscreen . fullwidth) and the tool bar on top.  But that's
irrelevant wrt to how many characters fit on a line, so drop it.

 > If so, the result is the same in master with and without you
 > recent patch: there's a bit of space between the last character and the
 > right fringe, but less than one column's worth.

Probably because a fullboth frame's text width is not a multiple of the
character width.  What does evaluating (window--dump-frame) give on that
frame?  The result is in a buffer called *window-frame-dump*.  If the
second value I marked below is not the product of the first and third
value I marked you should see that.

frame pixel: 1680 x 984   cols/lines: 210 x 60   units: 8 x 16
                                                         ^
frame text pixel: 1648 x 968   cols/lines: 206 x 60
                   ^^^^                     ^^^
tool: 0  scroll: 16/16  fringe: 16  border: 0  right: 6  bottom: 6

 > Although, with your patch, I no longer observe the problem, in case you
 > want to do some ex post facto forensics, below is the minimal recipe I
 > came up with to show the problem.  Do emacs -Q in a build from master
 > without your patch, evaluate the code and then type `M-x srb-test'.

I can see it with that recipe.

Thanks, martin