From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Date: Thu, 05 Feb 2015 08:17:06 -0800 Organization: UCLA Computer Science Department Message-ID: <54D39782.2070106@cs.ucla.edu> References: <20150201003025.18138.95966@vcs.savannah.gnu.org> <54CDC38C.9080701@yandex.ru> <54CE05A0.2090701@cs.ucla.edu> <54D15CF5.3020809@cs.ucla.edu> <54D2BB6E.1040704@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1423153042 17274 80.91.229.3 (5 Feb 2015 16:17:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2015 16:17:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: joakim@verona.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 05 17:17:20 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJP7H-0004eo-7W for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 17:17:19 +0100 Original-Received: from localhost ([::1]:42917 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJP7G-0007ha-IJ for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 11:17:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJP79-0007hH-Hv for emacs-devel@gnu.org; Thu, 05 Feb 2015 11:17:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJP76-0006WT-9G for emacs-devel@gnu.org; Thu, 05 Feb 2015 11:17:11 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:40261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJP76-0006Vp-2D for emacs-devel@gnu.org; Thu, 05 Feb 2015 11:17:08 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 304A8A60087; Thu, 5 Feb 2015 08:17:07 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id STZ6LzFAhgER; Thu, 5 Feb 2015 08:17:06 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id C57CCA60081; Thu, 5 Feb 2015 08:17:06 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182456 Archived-At: On 02/05/2015 07:54 AM, joakim@verona.se wrote: > Is it possible to somehow regenerate your patch against whats in the > xwidget branch now? Sorry, my patch was all done by hand. > Some questions on the patch though: > > - Are you supposed to have a space after # on ifdefed macros? Nowadays it's considered nicer to indent there, e.g., see "#ifdef MAIN_PROGRAM" in lisp.h. Previously we didn't bother and a lot of the old code is still around, but we're talking new code here.... > - you mentioned some names are long, I suppose like > webkit_osr_mime_type_policy_typedecision_requested_callback > > These are generated algorithmically from signal names. Do you have an > idea for another algorithm? > The names should be static, so there's no need to worry about keeping them globally unique in the Emacs source code; they need to be unique only in xwidgets.c. For too-long names like that, how about using the same name as the g_signal_comment string, replacing "-" with "_"? E.g., mime_type_policy_decision_requested.