From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.bugs Subject: bug#19117: 25.0.50; emacs on x11 chooses different fonts for the same face sometimes Date: Thu, 05 Feb 2015 16:08:52 +0100 Message-ID: <54D38784.3050008@swipnet.se> References: <878uj674zh.fsf@secretsauce.net> <831tox7t03.fsf@gnu.org> <87a92zrj4b.fsf@secretsauce.net> <83egsbzbfu.fsf@gnu.org> <87r3vykdse.fsf@secretsauce.net> <87ppbikb6g.fsf@secretsauce.net> <54944426.6090900@yandex.ru> <878ui3jkx0.fsf@secretsauce.net> <5497D623.7040406@swipnet.se> <87bnmqi1ps.fsf@secretsauce.net> <87mw65momt.fsf@secretsauce.net> <87lhlonc7c.fsf@secretsauce.net> <83sifwaooq.fsf@gnu.org> <87h9wcmpaf.fsf@secretsauce.net> <838uhlbjqd.fsf@gnu.org> <87y4pklw65.fsf@secretsauce.net> <87a90w68co.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1423149025 9942 80.91.229.3 (5 Feb 2015 15:10:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2015 15:10:25 +0000 (UTC) Cc: 19117@debbugs.gnu.org To: Stefan Monnier , Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 05 16:10:22 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJO4U-0008Hb-3F for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Feb 2015 16:10:22 +0100 Original-Received: from localhost ([::1]:42583 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJO4J-0006qQ-5a for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Feb 2015 10:10:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJO4F-0006np-M2 for bug-gnu-emacs@gnu.org; Thu, 05 Feb 2015 10:10:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJO4A-0006jV-N5 for bug-gnu-emacs@gnu.org; Thu, 05 Feb 2015 10:10:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJO4A-0006jL-JL for bug-gnu-emacs@gnu.org; Thu, 05 Feb 2015 10:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YJO4A-0000fu-9R for bug-gnu-emacs@gnu.org; Thu, 05 Feb 2015 10:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Jan D." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Feb 2015 15:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19117-submit@debbugs.gnu.org id=B19117.14231489432516 (code B ref 19117); Thu, 05 Feb 2015 15:10:02 +0000 Original-Received: (at 19117) by debbugs.gnu.org; 5 Feb 2015 15:09:03 +0000 Original-Received: from localhost ([127.0.0.1]:34863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJO3C-0000eW-NA for submit@debbugs.gnu.org; Thu, 05 Feb 2015 10:09:02 -0500 Original-Received: from mailfe04.swip.net ([212.247.154.97]:45125 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YJO3A-0000e1-68 for 19117@debbugs.gnu.org; Thu, 05 Feb 2015 10:09:01 -0500 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe04.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 568991087; Thu, 05 Feb 2015 16:08:53 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99060 Archived-At: Stefan Monnier skrev den 2015-02-03 18:53: >> This is a gentle ping. Is there anything more I can do to get this >> merged? > > I could install it, but I really have no idea whether your patch does > the right thing, because I'm too unfamiliar with this code. > Jan? Handa? > The patch looks bigger than it is because lot of the diff is just increased indentation. I guess it looks OK. These old fonts are deprecated anyway, so if it does the right thing for the OP, I guess we can install it. But the comment here: + /* We skip the second pass unless we really need it. */ + if (!(NILP (list) /* No fonts found on the first pass */ + && skipped_some_scalable_fonts)) /* and we skipped some scalable ones. */ + break; looks like it really should be /* Fonts found on the first pass */ Jan D.