From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: Dumper issue, revisited; invalid realloc/free Date: Wed, 04 Feb 2015 15:34:40 -0500 Message-ID: <54D28260.40403@cornell.edu> References: <20150204175709.GX23507@brightrain.aerifal.cx> <83pp9pfqb3.fsf@gnu.org> <20150204191305.GY23507@brightrain.aerifal.cx> <83lhkdfpgc.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1423082104 17790 80.91.229.3 (4 Feb 2015 20:35:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2015 20:35:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii , Rich Felker Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 04 21:35:00 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJ6f4-0006Zg-O5 for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 21:34:58 +0100 Original-Received: from localhost ([::1]:38671 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ6f4-0002s0-2y for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 15:34:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ6f0-0002qZ-EJ for emacs-devel@gnu.org; Wed, 04 Feb 2015 15:34:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ6ex-0001nh-3c for emacs-devel@gnu.org; Wed, 04 Feb 2015 15:34:54 -0500 Original-Received: from limerock04.mail.cornell.edu ([128.84.13.244]:36667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ6ex-0001jh-0C; Wed, 04 Feb 2015 15:34:51 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t14KYjj9003882; Wed, 4 Feb 2015 15:34:45 -0500 Original-Received: from [172.160.100.214] (50-192-21-221-static.hfc.comcastbusiness.net [50.192.21.221]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t14KYiUV022424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 4 Feb 2015 15:34:45 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: <83lhkdfpgc.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 128.84.13.244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182401 Archived-At: On 2/4/2015 2:26 PM, Eli Zaretskii wrote: >> Date: Wed, 4 Feb 2015 14:13:05 -0500 >> From: Rich Felker >> Cc: emacs-devel@gnu.org >> >>> Yes. Several platforms (Cygwin and MinGW on MS-Windows) already do >>> exactly that. >> >> Where is the code that does this? I don't see it in alloc.c. > > The Cygwin code is in sheap.c, the MinGW code is in w32heap.c. > >> Is it only used when system_malloc=no? The case where it's really >> needed is for system_malloc=yes... > > MinGW uses that with system malloc. Not sure about Cygwin. Cygwin (in the master branch) uses gmalloc.c before dumping and the system malloc after dumping. See the code in gmalloc.c involving HYBRID_MALLOC. Ken