From: Dmitry Gutov <dgutov@yandex.ru>
To: Rupert Swarbrick <ruperts@broadcom.com>,
19732@debbugs.gnu.org, "Eric S. Raymond" <esr@thyrsus.com>
Subject: bug#19732: 25.0.50; Wrong type argument: arrayp when running vc-dir on a CVS repo
Date: Fri, 30 Jan 2015 20:34:40 +0200 [thread overview]
Message-ID: <54CBCEC0.9070705@yandex.ru> (raw)
In-Reply-To: <889oapgo1jl.fsf@broadcom.com>
Rupert, please try this patch instead:
<--
diff --git a/lisp/vc/vc-cvs.el b/lisp/vc/vc-cvs.el
index d803c16..707090a 100644
--- a/lisp/vc/vc-cvs.el
+++ b/lisp/vc/vc-cvs.el
@@ -1076,7 +1076,7 @@ Query all files in DIR if files is nil."
(if (and (not files) local (not (eq local 'only-file)))
(vc-cvs-dir-status-heuristic dir update-function)
(if (not files) (setq files (vc-expand-dirs (list dir) 'CVS)))
- (vc-cvs-command (current-buffer) 'async dir "-f" "status" files)
+ (vc-cvs-command (current-buffer) 'async files "-f" "status")
;; Alternative implementation: use the "update" command instead of
;; the "status" command.
;; (vc-cvs-command (current-buffer) 'async
<--
On 01/30/2015 03:12 PM, Rupert Swarbrick wrote:
> (apply #'vc-cvs-command
> (append (list (current-buffer) 'async dir "-f" "status")
> files))
>
> (which would be neater with a Common Lisp style apply: maybe there's a
> more standard emacs lisp idiom for this?)
AFAICS, they work the same. So you wouldn't need the `append'.
> I'm not sending a patch with this bug report because I still haven't
> gotten around to filing copyright assignment papers with the FSF,
> sorry. So someone else gets to do the typing...
Have you exceeded the allowed limit? 10-15 lines of code without
assignment are fine.
next prev parent reply other threads:[~2015-01-30 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 13:12 bug#19732: 25.0.50; Wrong type argument: arrayp when running vc-dir on a CVS repo Rupert Swarbrick
2015-01-30 18:34 ` Dmitry Gutov [this message]
2015-02-06 10:20 ` Rupert Swarbrick
2015-02-06 23:37 ` Dmitry Gutov
2015-01-30 18:35 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBCEC0.9070705@yandex.ru \
--to=dgutov@yandex.ru \
--cc=19732@debbugs.gnu.org \
--cc=esr@thyrsus.com \
--cc=ruperts@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.