From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kim Storm Newsgroups: gmane.emacs.bugs Subject: bug#19660: Acknowledgement (24.4.51; Crash in draw_row_fringe_bitmaps) Date: Mon, 26 Jan 2015 12:10:11 +0100 Message-ID: <54C62093.5010202@cua.dk> References: <54C1EA6B.3000007@swipnet.se> <768087C3-7B81-44FD-BCCC-629535681556@swipnet.se> <83386ysw1g.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1422270920 21870 80.91.229.3 (26 Jan 2015 11:15:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 Jan 2015 11:15:20 +0000 (UTC) Cc: 19660@debbugs.gnu.org To: Eli Zaretskii , "Jan D." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 26 12:15:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YFhdS-0008SG-13 for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Jan 2015 12:15:14 +0100 Original-Received: from localhost ([::1]:40991 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFhdR-0000WI-CG for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Jan 2015 06:15:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFhdK-0000Pc-Kg for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 06:15:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFhdH-0002b8-Fa for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 06:15:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFhdH-0002an-Cp for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 06:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YFhdG-0007IV-W2 for bug-gnu-emacs@gnu.org; Mon, 26 Jan 2015 06:15:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kim Storm Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jan 2015 11:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19660 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19660-submit@debbugs.gnu.org id=B19660.142227087527999 (code B ref 19660); Mon, 26 Jan 2015 11:15:02 +0000 Original-Received: (at 19660) by debbugs.gnu.org; 26 Jan 2015 11:14:35 +0000 Original-Received: from localhost ([127.0.0.1]:56627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFhcp-0007HX-Fh for submit@debbugs.gnu.org; Mon, 26 Jan 2015 06:14:35 -0500 Original-Received: from ispc3.dotserv.com ([178.20.216.13]:48945) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YFhcm-0007HJ-T5 for 19660@debbugs.gnu.org; Mon, 26 Jan 2015 06:14:33 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by ispc3.dotserv.com (Postfix) with ESMTP id AFCF38096E436; Mon, 26 Jan 2015 12:14:26 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ispc3.dotserv.com Original-Received: from ispc3.dotserv.com ([127.0.0.1]) by localhost (ispc3.dotserv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9agHdvU7hm+n; Mon, 26 Jan 2015 12:14:22 +0100 (CET) Original-Received: from [10.1.82.9] (1405ds6-amb.0.fullrate.dk [90.184.76.141]) (Authenticated sender: storm@cua.dk) by ispc3.dotserv.com (Postfix) with ESMTPSA id D1FF1804CA788; Mon, 26 Jan 2015 12:14:22 +0100 (CET) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: <83386ysw1g.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98754 Archived-At: On 2015-01-25 16:46, Eli Zaretskii wrote: >> From: "Jan D." >> Date: Sun, 25 Jan 2015 10:17:20 +0100 >> >> Fixed, but it would be nice to know why this function needs input blocked. > This was there since day one, according to the history. Unless Kim, > who wrote it (CC'ed), can recollect why he put the assertion there, > I'm afraid the reason is lost in time. My wild guess would be that > the reason is this function calls X APIs to actually draw stuff, and > many of those block input. Perhaps Kim wasn't sure whether input > should be blocked here. > > If no other information emerges, my suggestion would be to remove the > assertion on master, and see if we get any bug reports. > > Thanks. > Hi Eli Well, the comment above the function says that it must be called with input blocked, so the assert simply reflects that requirement. Usually, draw_row_fringe_bitmaps is called from draw_window_fringes which is guarded by block_input in all places. However, the call to draw_row_fringe_bitmaps in xdisp.c:expose_line is not explicitly guarded, but it is called from expose_window, which has comment: Call this function with input blocked. Looking at the code, this seems not to be true anymore, and so it triggers the assert ... I have no idea whether it is still needed to block input - but at the time, I'm sure the assert was reasonable. Kim