bug#19664: 24.4: eww.el why bury history buffer?

bug#19664: 24.4: eww.el why bury history buffer?

[Boruch Baum]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

Function eww-history-browse buries the eww-history buffer. That's
undesirable. The following seems to work for me.


(defun eww-history-browse ()
; improper use of 'when'. replaced with 'if (not' so that upo\
n error, the remainder of the function is not performed
; no need to quit window and bury buffer. undesirable, in fac\
t
; do need to get position in history
  "Browse the history under point in eww."
  (interactive)
  (if (not (equal (buffer-name) "*eww history*"))
    (user-error "Current buffer is not the eww history buffer\
")
   (setq element (get-text-property (line-beginning-position)\
 'eww-history)
         position (1- (line-number-at-pos))
         history eww-history)
   (if (not element)
     (user-error "No history on the current line")
    (if (get-buffer "*eww*")
      (set-buffer "*eww*")
     (set-buffer (get-buffer-create "*eww*"))
     (remove-overlays)
     (eww-mode))
    (setq eww-history-position position
          eww-history history)
    (eww-restore-history element))))

-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#19664: 24.4: eww.el why bury history buffer?

[Lars Ingebrigtsen]

Boruch Baum <boruch_baum@gmx.com> writes:

> Function eww-history-browse buries the eww-history buffer. That's
> undesirable.

Hm...  Yeah, that does seem really odd.  I'll make it stop doing that.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#19664: 24.4: eww.el why bury history buffer?

[Lars Ingebrigtsen]

Boruch Baum <boruch_baum@gmx.com> writes:

> Function eww-history-browse buries the eww-history buffer. That's
> undesirable. The following seems to work for me.

I changed my mind.  The way it works seem to be the way Emacs does most
of these "help" buffers.  You hit `H', and the frame is split into two
windows.  Hitting `RET' on an item removes the history window and you're
back to just one eww buffer.

So I don't really see anything wrong here.  What is it that you find
undesirable?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

bug#19664: 24.4: eww.el why bury history buffer?

[Boruch Baum]

[-- Attachment #1: Type: text/plain, Size: 878 bytes --]

On 01/24/2015 09:57 PM, Lars Ingebrigtsen wrote:
> Boruch Baum <boruch_baum@gmx.com> writes:
> 
>> Function eww-history-browse buries the eww-history buffer. That's
>> undesirable. The following seems to work for me.
> 
> I changed my mind.  The way it works seem to be the way Emacs does most
> of these "help" buffers.  You hit `H', and the frame is split into two
> windows.  Hitting `RET' on an item removes the history window and you're
> back to just one eww buffer.
> 
> So I don't really see anything wrong here.  What is it that you find
> undesirable?
> 
Personally, I keep the frame split in C-x 3 fashion, and like having
*eww histry* next to *eww* for reading and reviewing pages offline. It's
not a big deal, just a user preference, what I find easy on my eyes.

-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

bug#19664: 24.4: eww.el why bury history buffer?

[Lars Ingebrigtsen]

Boruch Baum <boruch_baum@gmx.com> writes:

> Personally, I keep the frame split in C-x 3 fashion, and like having
> *eww histry* next to *eww* for reading and reviewing pages offline. It's
> not a big deal, just a user preference, what I find easy on my eyes.

Right.  I can see wanting to do that.  It would be consistent with the
way `M-x grep' works, for instance, but that's used for scanning quickly
through many hits, while the eww history (and bookmarks) aren't usually
used that way.

I think.

So I'm closing this bug.  If somebody wants to revisit this later, they
can do that.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/