From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#19466: 25.0.50; xref-find-def doesn't find C functions Date: Wed, 21 Jan 2015 17:54:07 +0100 Message-ID: <54BFD9AF.10002@gmx.at> References: <8361cucl3u.fsf@gnu.org> <54A230CD.3040309@yandex.ru> <83vbktb1ct.fsf@gnu.org> <54A2EE15.3020406@yandex.ru> <831tnhasx0.fsf@gnu.org> <54A6DAF6.5070605@yandex.ru> <831tna9tmr.fsf@gnu.org> <54A9C94F.8040701@yandex.ru> <83vbkl99vm.fsf@gnu.org> <54B8878A.4050506@yandex.ru> <54B8C22B.3080200@gmx.at> <54BC7A77.5020307@yandex.ru> <54BCC033.2010104@gmx.at> <54BD076E.6090707@yandex.ru> <54BE0B5A.6060706@gmx.at> <54BE4693.5050804@yandex.ru> <54BE6B59.5090404@gmx.at> <54BF5345.9090303@yandex.ru> <54BF843E.10907@gmx.at> <54BFB6A1.8050802@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1421859329 10877 80.91.229.3 (21 Jan 2015 16:55:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Jan 2015 16:55:29 +0000 (UTC) Cc: 19466@debbugs.gnu.org, Helmut Eller To: Dmitry Gutov , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 21 17:55:24 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YDyYt-0001ha-Ma for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jan 2015 17:55:23 +0100 Original-Received: from localhost ([::1]:49191 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDyYs-000842-Rd for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jan 2015 11:55:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDyYm-000816-Bw for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:55:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDyYY-0008Q3-Qe for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:55:16 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDyYY-0008Pa-Jy for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YDyYY-0005hl-5V for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jan 2015 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19466 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19466-submit@debbugs.gnu.org id=B19466.142185926621876 (code B ref 19466); Wed, 21 Jan 2015 16:55:02 +0000 Original-Received: (at 19466) by debbugs.gnu.org; 21 Jan 2015 16:54:26 +0000 Original-Received: from localhost ([127.0.0.1]:52047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDyXx-0005gl-Qf for submit@debbugs.gnu.org; Wed, 21 Jan 2015 11:54:26 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:64742) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDyXw-0005gY-6l for 19466@debbugs.gnu.org; Wed, 21 Jan 2015 11:54:25 -0500 Original-Received: from [188.22.33.74] ([188.22.33.74]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0McEI3-1YTaPy0IfH-00JaAT; Wed, 21 Jan 2015 17:54:13 +0100 In-Reply-To: <54BFB6A1.8050802@yandex.ru> X-Provags-ID: V03:K0:FHH0ZRqfqHsa/Mpg+Gzokv9qMQ2jrNUKx5Wb9fFW/UjiIFzWiMT wSkB14xEHCJlsIolTpicFLvQ3XPrXEaLl9+m32vSaXPOskGUyEJ1FtbYMXxR0N/p/vDSI89 dhErGjqWaKxNOSsbluESyOdmBLKCcRmwj4pMhVRgSO9FzbeUONbDtmadkhfIPh5drEc5ot7 qTALVNnswyVkCR66vkxcg== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98550 Archived-At: > "current" would be good, but "while finding xrefs" is iffy: we actually try to ignore instances of buffers being current while we display them (see xref--inhibit-mark-selected). In any case please stick to the "`current' is a predicate for buffers and `selected' is a predicate for windows and frames" convention. >> And for `xref-quit' I'd describe the standard behavior first and the >> KILL behavior afterwards. > > Would you like to suggest a specific wording? I'll try to as soon as I know what it does. Usually the "If optional argument KILL is non-nil ..." idiom should appear after describing the normal behavior. >> Also I'm not sure it it's just cosmetics but >> shouldn't the >> >> (pcase-dolist (`(,buf . ,win) history) >> (when (and (window-live-p win) >> (eq buf (window-buffer win))) >> (quit-window nil win))) >> >> precede the >> >> (when kill >> (let ((xref--inhibit-mark-selected t) >> kill-buffer-query-functions) >> (dolist (buf xref--temporary-buffers) >> (unless (buffer-local-value 'xref--selected buf) >> (kill-buffer buf))) >> (setq xref--temporary-buffers nil))) >> >> part? > > Probably, but there's likely not much difference at the moment. xref > doesn't pop any new windows, ... well, it did so here all the time ... > so we shouldn't miss on deleting those when quitting temporary buffers. Are you sure? Suppose `xref-show-location-at-point' reused a window showing a buffer A for showing a buffer B instead. Now `xref-quit' would kill B which should again show A instead. But here you rely on `kill-buffer' (that is `replace-buffer-in-windows') DTRT. >> I can't test it currently because I always get >> >> Debugger entered--Lisp error: (args-out-of-range "" 0) >> help-function-arglist(#[257 "\300\207" ["(No location)"] 2 "(No >> location)\n\n(fn ##)"] preserve-names) >> eieio--defmethod(xref-location-group nil xref-bogus-location #[257 >> "\300\207" ["(No location)"] 2 "(No location)\n\n(fn ##)"]) > > I'm sure Someone(tm) will fix that right away. :) For some value of "right away" :) >> > xref-goto-xref calls xref-quit without the KILL argument, so the >> temporary buffers are not cleared if you make a choice and press RET. >> >> You can redisplay the *xref* buffer and provide the KILL there. > > You mean, for the user to switch to the buried xref buffer, then press C-u q? That's quite a few keypresses. Then you probably want the KILL argument for `xref-goto-xref' too. >> >> previous-/next-history-element >> > >> > Not sure what these are. >> >> Something like typing M-. doing something else and typing M-. again. At >> this time up/down should get you the next/previous history elements of >> your xref searches. > > You mean in the current interface? I'm confused. When xref prompts me with Find definitions of: I'd expect to be able to browse my history of definitions I tried or succeeded to find. > With xref, we already sorta have both as features (C-u M-x xref-find-definitions and M-x xref-find-apropos). OK. They all work well in my gdb buffer. So it shouldn't be too hard. martin