From: martin rudalics <rudalics@gmx.at>
To: Dmitry Gutov <dgutov@yandex.ru>, Eli Zaretskii <eliz@gnu.org>
Cc: 19466@debbugs.gnu.org, Helmut Eller <eller.helmut@gmail.com>
Subject: bug#19466: 25.0.50; xref-find-def doesn't find C functions
Date: Wed, 21 Jan 2015 17:54:07 +0100 [thread overview]
Message-ID: <54BFD9AF.10002@gmx.at> (raw)
In-Reply-To: <54BFB6A1.8050802@yandex.ru>
> "current" would be good, but "while finding xrefs" is iffy: we actually try to ignore instances of buffers being current while we display them (see xref--inhibit-mark-selected).
In any case please stick to the "`current' is a predicate for buffers
and `selected' is a predicate for windows and frames" convention.
>> And for `xref-quit' I'd describe the standard behavior first and the
>> KILL behavior afterwards.
>
> Would you like to suggest a specific wording?
I'll try to as soon as I know what it does. Usually the "If optional
argument KILL is non-nil ..." idiom should appear after describing the
normal behavior.
>> Also I'm not sure it it's just cosmetics but
>> shouldn't the
>>
>> (pcase-dolist (`(,buf . ,win) history)
>> (when (and (window-live-p win)
>> (eq buf (window-buffer win)))
>> (quit-window nil win)))
>>
>> precede the
>>
>> (when kill
>> (let ((xref--inhibit-mark-selected t)
>> kill-buffer-query-functions)
>> (dolist (buf xref--temporary-buffers)
>> (unless (buffer-local-value 'xref--selected buf)
>> (kill-buffer buf)))
>> (setq xref--temporary-buffers nil)))
>>
>> part?
>
> Probably, but there's likely not much difference at the moment. xref
> doesn't pop any new windows,
... well, it did so here all the time ...
> so we shouldn't miss on deleting those when quitting temporary buffers.
Are you sure? Suppose `xref-show-location-at-point' reused a window
showing a buffer A for showing a buffer B instead. Now `xref-quit'
would kill B which should again show A instead. But here you rely on
`kill-buffer' (that is `replace-buffer-in-windows') DTRT.
>> I can't test it currently because I always get
>>
>> Debugger entered--Lisp error: (args-out-of-range "" 0)
>> help-function-arglist(#[257 "\300\207" ["(No location)"] 2 "(No
>> location)\n\n(fn ##)"] preserve-names)
>> eieio--defmethod(xref-location-group nil xref-bogus-location #[257
>> "\300\207" ["(No location)"] 2 "(No location)\n\n(fn ##)"])
>
> I'm sure Someone(tm) will fix that right away. :)
For some value of "right away" :)
>> > xref-goto-xref calls xref-quit without the KILL argument, so the
>> temporary buffers are not cleared if you make a choice and press RET.
>>
>> You can redisplay the *xref* buffer and provide the KILL there.
>
> You mean, for the user to switch to the buried xref buffer, then press C-u q? That's quite a few keypresses.
Then you probably want the KILL argument for `xref-goto-xref' too.
>> >> previous-/next-history-element
>> >
>> > Not sure what these are.
>>
>> Something like typing M-. doing something else and typing M-. again. At
>> this time up/down should get you the next/previous history elements of
>> your xref searches.
>
> You mean in the current interface? I'm confused.
When xref prompts me with
Find definitions of:
I'd expect to be able to browse my history of definitions I tried or
succeeded to find.
> With xref, we already sorta have both as features (C-u M-x xref-find-definitions and M-x xref-find-apropos).
OK. They all work well in my gdb buffer. So it shouldn't be too hard.
martin
next prev parent reply other threads:[~2015-01-21 16:54 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 19:27 bug#19466: 25.0.50; xref-find-def doesn't find C functions Eli Zaretskii
2014-12-30 4:57 ` Dmitry Gutov
2014-12-30 15:31 ` Eli Zaretskii
2014-12-30 18:05 ` Stefan Monnier
2014-12-30 18:25 ` Dmitry Gutov
2014-12-30 18:34 ` Eli Zaretskii
2014-12-30 18:38 ` Dmitry Gutov
2014-12-30 22:44 ` Stefan Monnier
2015-01-02 17:52 ` Dmitry Gutov
2015-01-04 20:10 ` Stefan Monnier
2015-01-04 20:29 ` Eli Zaretskii
2015-01-04 23:14 ` Dmitry Gutov
2015-01-05 3:36 ` Eli Zaretskii
2015-01-05 6:11 ` Stefan Monnier
2015-01-16 3:37 ` Dmitry Gutov
2015-01-16 7:47 ` martin rudalics
2015-01-16 9:04 ` Eli Zaretskii
2015-01-16 9:28 ` martin rudalics
2015-01-19 3:31 ` Dmitry Gutov
2015-01-19 8:28 ` martin rudalics
2015-01-19 13:32 ` Dmitry Gutov
2015-01-20 8:01 ` martin rudalics
2015-01-20 12:14 ` Dmitry Gutov
2015-01-20 14:51 ` martin rudalics
2015-01-21 7:20 ` Dmitry Gutov
2015-01-21 10:49 ` martin rudalics
2015-01-21 14:24 ` Dmitry Gutov
2015-01-21 16:54 ` martin rudalics [this message]
2015-01-21 18:00 ` martin rudalics
2015-01-21 20:02 ` Stefan Monnier
2015-01-22 2:32 ` Dmitry Gutov
2015-01-22 18:22 ` martin rudalics
2015-01-21 19:02 ` Dmitry Gutov
2015-01-22 2:26 ` Dmitry Gutov
2015-01-22 18:22 ` martin rudalics
2015-01-19 17:41 ` Eli Zaretskii
2015-01-20 2:54 ` Dmitry Gutov
2015-01-20 17:24 ` Eli Zaretskii
2015-01-20 20:49 ` Dmitry Gutov
2015-01-21 16:25 ` Eli Zaretskii
2015-01-22 2:43 ` Dmitry Gutov
2015-01-22 18:02 ` Eli Zaretskii
2015-01-22 21:02 ` Dmitry Gutov
2015-01-23 9:03 ` Eli Zaretskii
2015-01-23 17:34 ` Dmitry Gutov
2015-01-23 21:03 ` Eli Zaretskii
2015-01-23 22:23 ` Dmitry Gutov
2015-01-24 9:40 ` Eli Zaretskii
2015-01-24 16:47 ` Dmitry Gutov
2015-01-31 8:52 ` Eli Zaretskii
2015-02-01 2:24 ` Dmitry Gutov
2015-02-01 16:01 ` Eli Zaretskii
2015-02-01 20:11 ` Dmitry Gutov
2015-02-01 20:30 ` Eli Zaretskii
2015-02-01 20:53 ` Dmitry Gutov
2015-02-02 3:32 ` Eli Zaretskii
2015-02-23 2:01 ` Dmitry Gutov
2015-01-24 18:43 ` Project support and completions (Was: Re: bug#19466: 25.0.50; xref-find-def doesn't find C functions) Dmitry Gutov
2015-01-24 22:26 ` Eli Zaretskii
2015-01-24 23:25 ` Dmitry Gutov
2015-01-25 0:21 ` John Yates
2015-01-25 16:09 ` Eli Zaretskii
2015-01-29 21:19 ` John Yates
2015-01-30 6:19 ` Eli Zaretskii
2015-01-30 13:39 ` John Yates
2015-01-30 15:36 ` Eli Zaretskii
2015-01-30 18:14 ` Project support and completions Stefan Monnier
2015-01-30 21:34 ` Eli Zaretskii
2015-01-31 6:37 ` Stefan Monnier
2015-01-31 7:38 ` Eli Zaretskii
2015-01-31 22:52 ` Stefan Monnier
2015-02-01 20:42 ` Stephen Leake
2015-01-30 16:17 ` Stefan Monnier
2015-01-30 16:26 ` Eli Zaretskii
2015-01-30 20:36 ` Scott Frazer
2015-01-25 16:08 ` Eli Zaretskii
2015-01-25 18:18 ` Dmitry Gutov
2015-01-25 19:22 ` Eli Zaretskii
2015-01-25 23:03 ` Dmitry Gutov
2015-01-26 5:51 ` Eli Zaretskii
2015-01-25 18:31 ` Stephen Leake
2015-01-25 15:01 ` Stefan Monnier
2015-01-25 16:01 ` Eli Zaretskii
2015-01-25 18:33 ` Stefan Monnier
2015-01-25 19:24 ` Eli Zaretskii
2015-01-25 22:43 ` Stefan Monnier
2015-01-25 23:05 ` Dmitry Gutov
2015-01-26 3:46 ` Stefan Monnier
2015-01-26 4:23 ` Dmitry Gutov
2015-01-26 15:07 ` Stefan Monnier
2015-01-26 17:33 ` Eli Zaretskii
2015-01-26 18:51 ` Stephen Leake
2015-01-26 5:44 ` Eli Zaretskii
2015-01-26 15:11 ` Stefan Monnier
2015-01-26 17:34 ` Eli Zaretskii
2015-01-23 21:15 ` bug#19466: 25.0.50; xref-find-def doesn't find C functions Stefan Monnier
2015-01-23 21:34 ` Eli Zaretskii
2015-01-16 9:00 ` Eli Zaretskii
2015-01-04 22:14 ` Dmitry Gutov
2014-12-30 20:43 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BFD9AF.10002@gmx.at \
--to=rudalics@gmx.at \
--cc=19466@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=eller.helmut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.