Re: Page navigation in doc-view.el

[Vaidheeswaran <vaidheeswaran.chinnaraju@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 677 bytes --]

On Thursday 15 January 2015 09:35 PM, Stefan Monnier wrote:
> I think it would make sense to make `n' jump to the beginning of the
> next page (and `p' go to the bottom of the previous page) when
> doc-view-continuous is non-nil.
>
> For M-g M-g, maybe as well (again conditional on doc-view-continuous).

I am attaching a patch.  Fyi, I have queued up an assignment request 
already and I am waiting for a response.

> Of course, I also think that doc-view-continuous should ideally render
> all the pages at the same time in the buffer (stacked vertically), so
> you can scroll through them with the usual scrolling commands, but that
> will take a good bit more work.

Ok.


[-- Attachment #2: 0001-Fix-page-navigation-when-doc-view-continuous-is-nil.patch --]
[-- Type: text/x-patch, Size: 1259 bytes --]

From f72775037ecb8ed9dadbe0775e969e90663dd86f Mon Sep 17 00:00:00 2001
From: Vaidheeswaran C <vaidheeswaran.chinnaraju@gmail.com>
Date: Sun, 18 Jan 2015 13:29:04 +0530
Subject: [PATCH] Fix page navigation when `doc-view-continuous' is nil.

---
 lisp/doc-view.el |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 0e63d37..21a0883 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -527,6 +527,7 @@ Typically \"page-%s.png\".")
                  (format doc-view--image-file-pattern page)
                  (doc-view--current-cache-dir))))
       (doc-view-insert-image file :pointer 'arrow)
+      (unless doc-view-continuous (image-bob))
       (when (and (not (file-exists-p file))
                  doc-view--current-converter-processes)
         ;; The PNG file hasn't been generated yet.
@@ -553,7 +554,8 @@ Typically \"page-%s.png\".")
 (defun doc-view-previous-page (&optional arg)
   "Browse ARG pages backward."
   (interactive "p")
-  (doc-view-goto-page (- (doc-view-current-page) (or arg 1))))
+  (doc-view-goto-page (- (doc-view-current-page) (or arg 1)))
+  (unless doc-view-continuous (image-eob)))
 
 (defun doc-view-first-page ()
   "View the first page."
-- 
1.7.2.5