From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#19493: [PATCH] Fix trailing ... for outline-toggle-children Date: Fri, 16 Jan 2015 16:32:34 +0300 Message-ID: <54B912F2.8060607@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1421415190 17054 80.91.229.3 (16 Jan 2015 13:33:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Jan 2015 13:33:10 +0000 (UTC) To: Oleh Krehel , 19493@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 16 14:33:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YC71R-0007kC-4A for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Jan 2015 14:33:09 +0100 Original-Received: from localhost ([::1]:55727 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC71Q-000778-Fx for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Jan 2015 08:33:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC71N-000773-MY for bug-gnu-emacs@gnu.org; Fri, 16 Jan 2015 08:33:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YC71K-0006fx-G9 for bug-gnu-emacs@gnu.org; Fri, 16 Jan 2015 08:33:05 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YC71K-0006fp-Cb for bug-gnu-emacs@gnu.org; Fri, 16 Jan 2015 08:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YC71J-0003Xj-Tm for bug-gnu-emacs@gnu.org; Fri, 16 Jan 2015 08:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Jan 2015 13:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 19493-submit@debbugs.gnu.org id=B19493.142141516313587 (code B ref 19493); Fri, 16 Jan 2015 13:33:01 +0000 Original-Received: (at 19493) by debbugs.gnu.org; 16 Jan 2015 13:32:43 +0000 Original-Received: from localhost ([127.0.0.1]:58565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YC710-0003X4-Vj for submit@debbugs.gnu.org; Fri, 16 Jan 2015 08:32:43 -0500 Original-Received: from mail-lb0-f171.google.com ([209.85.217.171]:50716) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YC70z-0003Wq-Ep for 19493@debbugs.gnu.org; Fri, 16 Jan 2015 08:32:42 -0500 Original-Received: by mail-lb0-f171.google.com with SMTP id w7so18492070lbi.2 for <19493@debbugs.gnu.org>; Fri, 16 Jan 2015 05:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=PoMV1oHmWQ7KhWY5Hj60qDo7t0lpRrP1P8Olfkta68o=; b=ke0w+gQ8URQmzBWEksKNF8uSBnxeUxHvbSxJXiUBahwVG12FRpYMBlXvcvoLDdt89x aBsUVW7CqlqaNtwb0swxoqoWysQzJeE0+qAbUXr0Z8kxiCjQyZeLuGM/THuxhsiOJCwU Wgz2CHhYZOP+ZSNzYP3gBdTvu1vFKM4a2Dp9LacdEwsmaYW9AW6n8eF/geRDC4lqd/a3 ZhAQXj9vHhIBt9maemn3lX5GvAGzbGmMqLX5fSdlgiu1A0045WWMpR+QVY170aZEVbn9 Hw0cSrh3NV2tf65yEl4y9T+ZARFJAG05vCQ9y/oI92tR8YlRgOSvkF+Htg727FoaQris r9Jg== X-Received: by 10.112.154.70 with SMTP id vm6mr15729170lbb.18.1421415155577; Fri, 16 Jan 2015 05:32:35 -0800 (PST) Original-Received: from [192.168.1.3] ([178.252.98.87]) by mx.google.com with ESMTPSA id au10sm879874lbc.31.2015.01.16.05.32.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jan 2015 05:32:34 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Thunderbird/33.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98420 Archived-At: Hi! This piece of code doesn't make sense to me: On 01/03/2015 03:04 AM, Oleh Krehel wrote: - (if (and (bolp) (or outline-blank-line (eobp)) (not (bobp))) + (if (and (bolp) (or outline-blank-line (eobp)) + (not (bobp)) (not (eobp))) The second condition already checks for `eobp', so apparently the function is supposed to handle the end-of-buffer case. If that was an error in someone's thinking, the patch should correct that as well. But maybe the fix should do something in the caller instead.