From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.bugs Subject: bug#20182: 24.4.91; [GTK3] Vertical scroll bar is "indented" from right edge of frame Date: Tue, 24 Mar 2015 22:38:13 +0100 Message-ID: <54B90A62-61CB-42DA-9E08-69D80D0C83CB@swipnet.se> References: <87h9tbwnfo.fsf@moondust.localdomain> <55106F6C.7010900@gmx.at> <874mpbwglg.fsf@moondust.localdomain> <55108A2C.1010608@gmx.at> <551141A6.3050404@gmx.at> <73119439-0C7D-4A2E-BB1E-4D4B0E95E080@swipnet.se> <87619qnn8s.fsf@moondust.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1427233167 6413 80.91.229.3 (24 Mar 2015 21:39:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 24 Mar 2015 21:39:27 +0000 (UTC) Cc: "20182@debbugs.gnu.org" <20182@debbugs.gnu.org> To: "N. Jackson" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 24 22:39:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YaWXW-0001Su-BL for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Mar 2015 22:39:10 +0100 Original-Received: from localhost ([::1]:34670 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaWXV-0008MK-FF for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Mar 2015 17:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaWXR-0008ME-SN for bug-gnu-emacs@gnu.org; Tue, 24 Mar 2015 17:39:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YaWXO-00036q-N9 for bug-gnu-emacs@gnu.org; Tue, 24 Mar 2015 17:39:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45545) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YaWXO-00036l-KJ for bug-gnu-emacs@gnu.org; Tue, 24 Mar 2015 17:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YaWXO-0001up-9e for bug-gnu-emacs@gnu.org; Tue, 24 Mar 2015 17:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Jan D." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Mar 2015 21:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20182 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20182-submit@debbugs.gnu.org id=B20182.14272331007310 (code B ref 20182); Tue, 24 Mar 2015 21:39:02 +0000 Original-Received: (at 20182) by debbugs.gnu.org; 24 Mar 2015 21:38:20 +0000 Original-Received: from localhost ([127.0.0.1]:35321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YaWWi-0001tp-09 for submit@debbugs.gnu.org; Tue, 24 Mar 2015 17:38:20 -0400 Original-Received: from mailfe05.swip.net ([212.247.154.129]:41430 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YaWWe-0001tX-ST for 20182@debbugs.gnu.org; Tue, 24 Mar 2015 17:38:18 -0400 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe05.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 578458396; Tue, 24 Mar 2015 22:38:09 +0100 X-Mailer: iPad Mail (12D508) In-Reply-To: <87619qnn8s.fsf@moondust.localdomain> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100900 Archived-At: Hi. > 24 mar 2015 kl. 21:39 skrev N. Jackson : >=20 > At 13:16 -0300 on Tuesday 2015-03-24, Jan D. wrote: >=20 >>>> 24 mar 2015 kl. 11:51 skrev martin rudalics : >>>>=20 >>>> 16 was the hardcoded width for Gtk2. >>>=20 >>> Does that mean gtk_widget_style_get is broken for Gtk2? >>=20 >> It means that the width it returns is 16. >>=20 >>>=20 >>>> You can #ifdef it. >>>=20 >>> Like >>>=20 >>> #if (! GTK_CHECK_VERSION (3, 0, 0) >>> if (w < 16) w =3D 16; >>> #endif >>>=20 >>=20 >> Yes, or=20 >> #ifndef HAVE_GTK3 >> ... >>=20 >> Jan D. >=20 > Of course, if gtk_widget_style_get() only returns 16 when the GDK > version is not GDK3, then this line >=20 > if (w < 16) w =3D 16; >=20 > in update_theme_scrollbar_width() of gtkutil.c does nothing when the > GDK version is not GDK3. >=20 > Since we don't need this adjustment with GDK3 (with which > gtk_widget_style_get() returns the correct value from the toolkit), I > replaced the offending line with >=20 > #ifndef HAVE_GTK3 > /* if (w < 16) w =3D 16; */ > eassert (w =3D=3D 16);=20 > #endif=20 >=20 > and this seems to fix the bug for me. (Of course, removing the offending > line altogether has the same effect.) You have added an assert that is dependent on how non-Emacs code behaves. Th= at is wrong in all possible ways. >=20 > I don't have a GTK2 system to test on, though. If you are adding asserts, you should be sure that all Gtk+ 2 versions behav= es like this, which includes all patched versions that are used by distribut= ions.=20 Jan D.=20 >=20 > Note: The badness is somehow encoded in my desktop file as well, so to > see that the fix was working I had to rename my desktop file or run with > emacs --no-desktop. >=20