Re: #2 [Was: Re: Function attributes for make-docfile]

[Dmitry Antipov <dmantipov@yandex.ru>]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

On 01/14/2015 10:44 PM, Paul Eggert wrote:

> There are several possibilities for how to fix this in a less-ugly way, including:
>
> 1.  Omit -Wsuggest-attribute=const.
>
> 2.  Omit -Wredundant-decls.
>
> 3.  Make make-docfile.c even smarter and/or trickier.

2) was added to cleanup global namespace, which is typically polluted in mature
projects, and I think this is still useful.

Why not use #pragma in the way similar to bytecode.c?  IMO local ugliness is
always better than the global one :-).

Dmitry


[-- Attachment #2: pragma_disable_warning.patch --]
[-- Type: text/x-diff, Size: 1472 bytes --]

diff --git a/lib-src/make-docfile.c b/lib-src/make-docfile.c
index 741fa4b..79d421a 100644
--- a/lib-src/make-docfile.c
+++ b/lib-src/make-docfile.c
@@ -729,18 +729,6 @@ write_globals (void)
 
 	  if (globals[i].flags & DEFUN_const)
 	    fputs (" ATTRIBUTE_CONST", stdout);
-	  else if (strcmp (globals[i].name, "Fnext_read_file_uses_dialog_p")
-		   == 0)
-	    {
-	      /* It would be nice to have a cleaner way to deal with this
-		 special hack.  */
-	      fputs (("\n"
-		      "#if ! (defined USE_GTK || defined USE_MOTIF \\\n"
-		      "       || defined HAVE_NS || defined HAVE_NTGUI)\n"
-		      "\tATTRIBUTE_CONST\n"
-		      "#endif\n"),
-		     stdout);
-	    }
 
 	  puts (";");
 	}
diff --git a/src/fileio.c b/src/fileio.c
index 6c443c9..31b117b 100644
--- a/src/fileio.c
+++ b/src/fileio.c
@@ -5736,6 +5736,11 @@ then any auto-save counts as "recent".  */)
 
 /* Reading and completing file names.  */
 
+#if 4 < __GNUC__ + (6 <= __GNUC_MINOR__)
+# pragma GCC diagnostic push
+# pragma GCC diagnostic ignored "-Wsuggest-attribute=const"
+#endif
+
 DEFUN ("next-read-file-uses-dialog-p", Fnext_read_file_uses_dialog_p,
        Snext_read_file_uses_dialog_p, 0, 0, 0,
        doc: /* Return t if a call to `read-file-name' will use a dialog.
@@ -5754,6 +5759,10 @@ before any other event (mouse or keypress) is handled.  */)
   return Qnil;
 }
 
+#if 4 < __GNUC__ + (6 <= __GNUC_MINOR__)
+# pragma GCC diagnostic pop
+#endif
+
 void
 init_fileio (void)
 {