From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: #2 [Was: Re: Function attributes for make-docfile] Date: Mon, 12 Jan 2015 23:29:53 -0800 Organization: UCLA Computer Science Department Message-ID: <54B4C971.7010209@cs.ucla.edu> References: <54B348E8.7080203@yandex.ru> <54B3604E.9020304@cs.ucla.edu> <54B3BDE3.8030602@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1421134221 3688 80.91.229.3 (13 Jan 2015 07:30:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 Jan 2015 07:30:21 +0000 (UTC) Cc: Emacs development discussions To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 13 08:30:14 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YAvva-0001ST-NH for ged-emacs-devel@m.gmane.org; Tue, 13 Jan 2015 08:30:14 +0100 Original-Received: from localhost ([::1]:37715 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAvvZ-0007uE-K8 for ged-emacs-devel@m.gmane.org; Tue, 13 Jan 2015 02:30:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAvvM-0007u4-Pl for emacs-devel@gnu.org; Tue, 13 Jan 2015 02:30:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAvvH-0006CS-PK for emacs-devel@gnu.org; Tue, 13 Jan 2015 02:30:00 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:39088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAvvH-0006CO-JO for emacs-devel@gnu.org; Tue, 13 Jan 2015 02:29:55 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id B4FD6A600D3; Mon, 12 Jan 2015 23:29:54 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2D1cV2-bWrpM; Mon, 12 Jan 2015 23:29:54 -0800 (PST) Original-Received: from [192.168.1.9] (pool-173-55-11-52.lsanca.fios.verizon.net [173.55.11.52]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 574C8A60025; Mon, 12 Jan 2015 23:29:54 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 In-Reply-To: <54B3BDE3.8030602@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181205 Archived-At: Dmitry Antipov wrote: > OK to install? I guess so, since you already installed it. :-) It looks good, but ther= e is a=20 problem when I configure as follows on Fedora 21 x86-64: ./configure --enable-gcc-warnings --with-x-toolkit=3Dno The resulting build fails as follows: CC fileio.o In file included from fileio.c:45:0: fileio.c: In function =E2=80=98Fnext_read_file_uses_dialog_p=E2=80=99: fileio.c:5739:40: error: function might be candidate for attribute =E2=80= =98const=E2=80=99=20 [-Werror=3Dsuggest-attribute=3Dconst] DEFUN ("next-read-file-uses-dialog-p", Fnext_read_file_uses_dialog_p, ^ lisp.h:2766:16: note: in definition of macro =E2=80=98DEFUN=E2=80=99 Lisp_Object fnname ^ cc1: all warnings being treated as errors Fnext_read_file_uses_dialog_p should be a const function if and only if=20 !(defined USE_MOTIF || defined HAVE_NTGUI || defined USE_GTK || defined=20 HAVE_NS), but the DEFUN syntax doesn't let one specify a function to be=20 conditionally const -- it's either always const or always non-const. Thi= s=20 problem existed before you installed this change, but I worry that the ch= ange=20 will make it harder to fix.