Re: #2 [Was: Re: Function attributes for make-docfile]

[Paul Eggert <eggert@cs.ucla.edu>]

Dmitry Antipov wrote:
> OK to install?

I guess so, since you already installed it.  :-)  It looks good, but there is a 
problem when I configure as follows on Fedora 21 x86-64:

./configure --enable-gcc-warnings --with-x-toolkit=no

The resulting build fails as follows:

   CC       fileio.o
In file included from fileio.c:45:0:
fileio.c: In function ‘Fnext_read_file_uses_dialog_p’:
fileio.c:5739:40: error: function might be candidate for attribute ‘const’ 
[-Werror=suggest-attribute=const]
  DEFUN ("next-read-file-uses-dialog-p", Fnext_read_file_uses_dialog_p,
                                         ^
lisp.h:2766:16: note: in definition of macro ‘DEFUN’
     Lisp_Object fnname
                 ^
cc1: all warnings being treated as errors


Fnext_read_file_uses_dialog_p should be a const function if and only if 
!(defined USE_MOTIF || defined HAVE_NTGUI || defined USE_GTK || defined 
HAVE_NS), but the DEFUN syntax doesn't let one specify a function to be 
conditionally const -- it's either always const or always non-const.  This 
problem existed before you installed this change, but I worry that the change 
will make it harder to fix.