From: Dmitry Gutov <dgutov@yandex.ru>
To: Oleh Krehel <o.krehel@tue.nl>, emacs-devel@gnu.org
Subject: Re: [PATCH] What's the quickest way to contribute?
Date: Tue, 13 Jan 2015 05:57:31 +0300 [thread overview]
Message-ID: <54B4899B.8010004@yandex.ru> (raw)
In-Reply-To: <CAJ1SQWCE29UB726Kx=SreSet-D23__7JGN3dokH6nJCYLf+-BA@mail.gmail.com>
On 01/08/2015 08:59 PM, Oleh Krehel wrote:
Regarding this patch:
> Finally, I attach one more patch that I'd like some feedback on.
> I was browsing replace.el and found this type of code:
>
> (delq nil (mapcar #'(lambda (buf)
> (when (buffer-live-p buf) buf))
> bufs))
>
> instead of this:
>
> (cl-remove-if-not #'buffer-live-p bufs)
>
> If this were my package, I would change it without batting an eye,
> since the latter code is more clear and algorithmically faster.
Personally, I'd hesitate to make a change like this unless there's a
semi-plausible scenario where this code is wrong (when a `buf' values
could be nil), or where the change in performance could plausibly be
noticed by a user. Since the number of buffers opened in Emacs is very
unlikely to be high enough, probably not.
And the code reads well enough.
> Or maybe there's a policy of not fixing things that aren't broke.
Mostly this.
Using `cl-' functions is allowed, but I guess there remains some amount
of prejudice against the CL coding style, and using those (more
complicated) functions when simpler ones can work just as well.
next prev parent reply other threads:[~2015-01-13 2:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 17:59 [PATCH] What's the quickest way to contribute? Oleh Krehel
2015-01-08 18:48 ` Eli Zaretskii
2015-01-08 19:04 ` Samer Masterson
2015-01-08 19:13 ` Dmitry Gutov
2015-01-09 0:01 ` Richard Stallman
2015-01-13 2:57 ` Dmitry Gutov [this message]
2015-01-13 5:10 ` Stefan Monnier
2015-01-13 11:15 ` Dmitry Gutov
2015-01-13 19:24 ` Stefan Monnier
2015-01-13 13:46 ` Oleh Krehel
2015-01-13 19:32 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B4899B.8010004@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=o.krehel@tue.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.