all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: 19514@debbugs.gnu.org
Subject: bug#19514: 25.0.50; byte-compile-file too tight-lipped
Date: Tue, 06 Jan 2015 15:30:51 -0800	[thread overview]
Message-ID: <54AC702B.4080403@cs.ucla.edu> (raw)
In-Reply-To: <b4mppatiity.fsf@jpl.org>

[-- Attachment #1: Type: text/plain, Size: 267 bytes --]

Hmm, well, dgnushack shouldn't rely on byte-compile-file outputting 
messages when not verbose.  One way to fix this is for dgnushack to set 
byte-compile-verbose, but that might make dgnushack *too* verbose.  So 
how about the attached patch to dgnushack instead?



[-- Attachment #2: gnus.diff --]
[-- Type: text/x-patch, Size: 1843 bytes --]

diff --git a/lisp/dgnushack.el b/lisp/dgnushack.el
index 9d862bd..237fbef 100644
--- a/lisp/dgnushack.el
+++ b/lisp/dgnushack.el
@@ -272,6 +272,11 @@ in `defcustom' forms."
 		 (equal (nth 1 form) ''nconc))
 	(setq form (cons 'mapcan (cdr last)))))))
 
+(defun dgnushack-compile-file (file)
+  "Byte-compile FILE after reporting that it's being compiled."
+  (message "Compiling %s..." file)
+  (byte-compile-file file))
+
 (defun dgnushack-compile-verbosely ()
   "Call dgnushack-compile with warnings ENABLED.  If you are compiling
 patches to gnus, you should consider modifying make.bat to call
@@ -349,10 +354,10 @@ This means that every warning will be reported as an error."
 	(if error-on-warn
 	    (let ((byte-compile-error-on-warn t))
 	      (unless (ignore-errors
-			(byte-compile-file file))
+			(dgnushack-compile-file file))
 		(setq compilesuccess nil)))
 	  (ignore-errors
-	    (byte-compile-file file)))))
+	    (dgnushack-compile-file file)))))
     compilesuccess))
 
 (defun dgnushack-recompile ()
@@ -383,8 +388,7 @@ This means that every warning will be reported as an error."
 	  (Custom-make-dependencies))
       (ad-unadvise 'directory-files))
     (when (featurep 'xemacs)
-      (message "Compiling %s..." dgnushack-cus-load-file)
-      (byte-compile-file dgnushack-cus-load-file))))
+      (dgnushack-compile dgnushack-cus-load-file))))
 
 (defun dgnushack-make-auto-load ()
   (require 'autoload)
@@ -455,8 +459,7 @@ This means that every warning will be reported as an error."
 ;;; gnus-load.el ends here
 ")
       ))
-  (message "Compiling %s..." dgnushack-gnus-load-file)
-  (byte-compile-file dgnushack-gnus-load-file)
+  (dgnushack-compile-file dgnushack-gnus-load-file)
   (when (featurep 'xemacs)
     (message "Creating dummy gnus-load.el...")
     (with-temp-file (expand-file-name "gnus-load.el")

  reply	other threads:[~2015-01-06 23:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05 11:10 bug#19514: 25.0.50; byte-compile-file too tight-lipped Katsumi Yamaoka
2015-01-06 23:30 ` Paul Eggert [this message]
2015-01-07  3:43 ` Katsumi Yamaoka
2015-01-07  7:04   ` Paul Eggert
2015-01-20  0:02 ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AC702B.4080403@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=19514@debbugs.gnu.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.