From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#19428: 25.0.50; X frame size inconsistent at start-up Date: Sat, 03 Jan 2015 12:22:34 -0800 Organization: UCLA Computer Science Department Message-ID: <54A84F8A.2000508@cs.ucla.edu> References: <87bnmwe6at.fsf@maru2.md5i.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070409090806060802070302" X-Trace: ger.gmane.org 1420316601 23558 80.91.229.3 (3 Jan 2015 20:23:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 Jan 2015 20:23:21 +0000 (UTC) To: 19428@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 03 21:23:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y7VE7-0003wV-8F for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Jan 2015 21:23:11 +0100 Original-Received: from localhost ([::1]:55257 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7VE6-0007oK-IA for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Jan 2015 15:23:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7VE2-0007o4-Nl for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2015 15:23:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y7VDz-0000Ow-Bi for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2015 15:23:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7VDz-0000Oq-7v for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2015 15:23:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y7VDy-00076i-QP for bug-gnu-emacs@gnu.org; Sat, 03 Jan 2015 15:23:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87bnmwe6at.fsf@maru2.md5i.com> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jan 2015 20:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19428 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19428-submit@debbugs.gnu.org id=B19428.142031656727292 (code B ref 19428); Sat, 03 Jan 2015 20:23:02 +0000 Original-Received: (at 19428) by debbugs.gnu.org; 3 Jan 2015 20:22:47 +0000 Original-Received: from localhost ([127.0.0.1]:35829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7VDj-000767-BP for submit@debbugs.gnu.org; Sat, 03 Jan 2015 15:22:47 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:35747) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y7VDg-00075y-Mq for 19428@debbugs.gnu.org; Sat, 03 Jan 2015 15:22:45 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 2E9AA39E80C4 for <19428@debbugs.gnu.org>; Sat, 3 Jan 2015 12:22:43 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HqFWgl16O5-4 for <19428@debbugs.gnu.org>; Sat, 3 Jan 2015 12:22:39 -0800 (PST) Original-Received: from [192.168.1.9] (pool-173-55-11-52.lsanca.fios.verizon.net [173.55.11.52]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id F38D939E801E for <19428@debbugs.gnu.org>; Sat, 3 Jan 2015 12:22:38 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97970 Archived-At: This is a multi-part message in MIME format. --------------070409090806060802070302 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Martin's patch caused GCC to complain if --enable-gcc-warnings is used; I installed the attached minor further change. --------------070409090806060802070302 Content-Type: text/x-diff; name="0001-Pacify-gcc-Wparentheses.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Pacify-gcc-Wparentheses.patch" >From 756acc864ade7f842109bd2d5f6f9a5b0a9e3153 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 3 Jan 2015 12:19:00 -0800 Subject: [PATCH] Pacify gcc -Wparentheses * frame.c (x_set_frame_parameters): Add parens (Bug#19428). --- src/ChangeLog | 5 +++++ src/frame.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/ChangeLog b/src/ChangeLog index 6d25fc2..12852b8 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,8 @@ +2015-01-03 Paul Eggert + + Pacify gcc -Wparentheses + * frame.c (x_set_frame_parameters): Add parens (Bug#19428). + 2015-01-03 Martin Rudalics * frame.c (x_set_frame_parameters): Call Fset_frame_size only if diff --git a/src/frame.c b/src/frame.c index bdc914f..5a0d142 100644 --- a/src/frame.c +++ b/src/frame.c @@ -3219,7 +3219,7 @@ x_set_frame_parameters (struct frame *f, Lisp_Object alist) if ((width_change && width != FRAME_TEXT_WIDTH (f)) || (height_change && height != FRAME_TEXT_HEIGHT (f)) - || f->can_x_set_window_size && (f->new_height || f->new_width)) + || (f->can_x_set_window_size && (f->new_height || f->new_width))) { /* If necessary provide default values for HEIGHT and WIDTH. Do that here since otherwise a size change implied by an -- 2.1.0 --------------070409090806060802070302--