From: Paul Eggert <eggert@cs.ucla.edu>
To: 19428@debbugs.gnu.org
Subject: bug#19428: 25.0.50; X frame size inconsistent at start-up
Date: Sat, 03 Jan 2015 12:22:34 -0800 [thread overview]
Message-ID: <54A84F8A.2000508@cs.ucla.edu> (raw)
In-Reply-To: <87bnmwe6at.fsf@maru2.md5i.com>
[-- Attachment #1: Type: text/plain, Size: 120 bytes --]
Martin's patch caused GCC to complain if --enable-gcc-warnings is used; I
installed the attached minor further change.
[-- Attachment #2: 0001-Pacify-gcc-Wparentheses.patch --]
[-- Type: text/x-diff, Size: 1319 bytes --]
From 756acc864ade7f842109bd2d5f6f9a5b0a9e3153 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sat, 3 Jan 2015 12:19:00 -0800
Subject: [PATCH] Pacify gcc -Wparentheses
* frame.c (x_set_frame_parameters): Add parens (Bug#19428).
---
src/ChangeLog | 5 +++++
src/frame.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/ChangeLog b/src/ChangeLog
index 6d25fc2..12852b8 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2015-01-03 Paul Eggert <eggert@cs.ucla.edu>
+
+ Pacify gcc -Wparentheses
+ * frame.c (x_set_frame_parameters): Add parens (Bug#19428).
+
2015-01-03 Martin Rudalics <rudalics@gmx.at>
* frame.c (x_set_frame_parameters): Call Fset_frame_size only if
diff --git a/src/frame.c b/src/frame.c
index bdc914f..5a0d142 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -3219,7 +3219,7 @@ x_set_frame_parameters (struct frame *f, Lisp_Object alist)
if ((width_change && width != FRAME_TEXT_WIDTH (f))
|| (height_change && height != FRAME_TEXT_HEIGHT (f))
- || f->can_x_set_window_size && (f->new_height || f->new_width))
+ || (f->can_x_set_window_size && (f->new_height || f->new_width)))
{
/* If necessary provide default values for HEIGHT and WIDTH. Do
that here since otherwise a size change implied by an
--
2.1.0
next prev parent reply other threads:[~2015-01-03 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 3:01 bug#19428: 25.0.50; Frame is wider (in chars) than normal non-deterministically Michael Welsh Duggan
2014-12-25 23:26 ` Michael Welsh Duggan
2014-12-30 16:01 ` martin rudalics
2014-12-30 22:47 ` Michael Welsh Duggan
2015-01-03 17:17 ` martin rudalics
2015-01-05 3:31 ` Michael Duggan
2015-01-05 7:08 ` martin rudalics
2015-01-05 7:53 ` martin rudalics
2015-01-03 20:22 ` Paul Eggert [this message]
2015-01-04 8:55 ` bug#19428: 25.0.50; X frame size inconsistent at start-up martin rudalics
2015-01-04 9:13 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A84F8A.2000508@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=19428@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.