From: Dmitry Antipov <dmantipov@yandex.ru>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Using stpcpy
Date: Tue, 23 Dec 2014 13:39:51 +0300 [thread overview]
Message-ID: <54994677.9080608@yandex.ru> (raw)
In-Reply-To: <54991006.8030208@cs.ucla.edu>
On 12/23/2014 09:47 AM, Paul Eggert wrote:
> Something like the attached patch, perhaps? Tested on
> both GNU/Linux and Solaris 10 (which lacks stpcpy).
Not quite; in particular, I would prefer (for example, in doc.c):
@@ -137,8 +136,7 @@ get_doc_string (Lisp_Object filepos, bool unibyte, bool definition)
{
/* Preparing to dump; DOC file is probably not installed.
So check in ../etc. */
- strcpy (name, "../etc/");
- strcat (name, SSDATA (file));
+ lispstpcpy (stpcpy (name, "../etc/"), file);
rather than:
@@ -137,8 +137,7 @@ get_doc_string (Lisp_Object filepos, bool unibyte, bool definition)
{
/* Preparing to dump; DOC file is probably not installed.
So check in ../etc. */
- strcpy (name, "../etc/");
- strcat (name, SSDATA (file));
+ strcpy (stpcpy (name, "../etc/"), SSDATA (file));
(because lispstpcpy can use known length of a Lisp_String and so call memcpy,
which should be faster than strcpy).
Dmitry
next prev parent reply other threads:[~2014-12-23 10:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 16:41 Using stpcpy Dmitry Antipov
2014-12-23 6:47 ` Paul Eggert
2014-12-23 10:39 ` Dmitry Antipov [this message]
2014-12-25 12:25 ` Paul Eggert
2014-12-25 17:42 ` Dmitry Antipov
2014-12-25 23:44 ` Paul Eggert
2014-12-26 17:06 ` Dani Moncayo
2014-12-26 21:24 ` Eli Zaretskii
2014-12-26 22:01 ` Dani Moncayo
2014-12-27 5:56 ` cg
2014-12-27 7:45 ` Eli Zaretskii
2014-12-27 10:26 ` Dani Moncayo
2014-12-27 10:39 ` Eli Zaretskii
2014-12-27 10:54 ` Dani Moncayo
2014-12-27 11:57 ` cg
2014-12-27 19:52 ` Eli Zaretskii
2014-12-27 20:03 ` David Engster
2014-12-27 20:17 ` Eli Zaretskii
2014-12-27 20:25 ` Eli Zaretskii
2014-12-27 20:49 ` David Engster
2014-12-28 3:36 ` Eli Zaretskii
2014-12-28 23:57 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54994677.9080608@yandex.ru \
--to=dmantipov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.