From: Paul Eggert <eggert@cs.ucla.edu>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: Andreas Schwab <schwab@suse.de>, emacs-devel@gnu.org
Subject: Re: master d20acfe: Fix Gnus registry pruning and sorting, and rename file
Date: Thu, 18 Dec 2014 13:03:09 -0800 [thread overview]
Message-ID: <5493410D.4020604@cs.ucla.edu> (raw)
In-Reply-To: <mvmk31p7yz5.fsf@hawking.suse.de>
[-- Attachment #1: Type: text/plain, Size: 220 bytes --]
On 12/18/2014 07:35 AM, Andreas Schwab wrote:
> No, the problem is that 'most-positive-fixnum is a symbol
I attempted to work around the problem by installing the attached
patch. Please let me know if it's not right.
[-- Attachment #2: 0001-registry.el-registry-db-Set-default-slot-later.patch --]
[-- Type: text/x-patch, Size: 1746 bytes --]
From 22e70c0440941ff8f77f990292bd20d79da3f99e Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 18 Dec 2014 13:00:15 -0800
Subject: [PATCH] * registry.el (registry-db): Set default slot later.
This is because its value is not a literal integer.
---
lisp/gnus/ChangeLog | 5 +++++
lisp/gnus/registry.el | 4 +++-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/lisp/gnus/ChangeLog b/lisp/gnus/ChangeLog
index 34dd919..6f0ea0f 100644
--- a/lisp/gnus/ChangeLog
+++ b/lisp/gnus/ChangeLog
@@ -1,3 +1,8 @@
+2014-12-18 Paul Eggert <eggert@cs.ucla.edu>
+
+ * registry.el (registry-db): Set default slot later.
+ This is because its value is not a literal integer.
+
2014-12-18 Stefan Monnier <monnier@iro.umontreal.ca>
* mm-util.el (mm-with-unibyte-current-buffer): Mark obsolete and
diff --git a/lisp/gnus/registry.el b/lisp/gnus/registry.el
index d086d64..cc18407 100644
--- a/lisp/gnus/registry.el
+++ b/lisp/gnus/registry.el
@@ -98,7 +98,7 @@
:type (or null float)
:documentation "The registry version.")
(max-size :initarg :max-size
- :initform most-positive-fixnum
+ ;; :initform most-positive-fixnum ;; see below
:type integer
:custom integer
:documentation "The maximum number of registry entries.")
@@ -123,6 +123,8 @@
(data :initarg :data
:type hash-table
:documentation "The data hashtable.")))
+;; Do this separately, since defclass doesn't allow expressions in :initform.
+(oset-default registry-db max-size most-positive-fixnum)
(defmethod initialize-instance :BEFORE ((this registry-db) slots)
"Check whether a registry object needs to be upgraded."
--
1.9.3
next prev parent reply other threads:[~2014-12-18 21:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141218112235.14020.81034@vcs.savannah.gnu.org>
[not found] ` <E1Y1ZAB-0003ek-Vw@vcs.savannah.gnu.org>
2014-12-18 14:33 ` master d20acfe: Fix Gnus registry pruning and sorting, and rename file Dmitry Gutov
2014-12-18 15:26 ` Eric Abrahamsen
2014-12-18 15:35 ` Andreas Schwab
2014-12-18 21:03 ` Paul Eggert [this message]
2014-12-19 1:41 ` Ted Zlatanov
2014-12-19 1:55 ` Eric Abrahamsen
2014-12-18 23:11 ` Katsumi Yamaoka
2014-12-19 7:39 ` [Emacs-diffs] " Glenn Morris
2014-12-19 12:18 ` Eric Abrahamsen
2014-12-20 11:19 ` Ted Zlatanov
2014-12-21 4:39 ` Eric Abrahamsen
2014-12-21 14:30 ` Stefan Monnier
2014-12-24 12:44 ` Ted Zlatanov
2014-12-24 12:46 ` Ted Zlatanov
2014-12-24 14:35 ` Eric Abrahamsen
2014-12-24 15:32 ` Ted Zlatanov
2014-12-25 4:27 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5493410D.4020604@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.