From: Dmitry Gutov <dgutov@yandex.ru>
To: bruce.connor.am@gmail.com
Cc: 19390@debbugs.gnu.org
Subject: bug#19390: 25.0.50; `package-activate' is too slow
Date: Thu, 18 Dec 2014 17:45:16 +0200 [thread overview]
Message-ID: <5492F68C.3090700@yandex.ru> (raw)
In-Reply-To: <CAAdUY-Kj0s3SjNKeyuUHOo7H2Uuaon8CSqEh3z1YHF8U+qEjUA@mail.gmail.com>
On 12/18/2014 05:15 PM, Artur Malabarba wrote:
> There's a bit of a small flaw with that approach, it's the reason I used
> find-library.
> If you just check load files against their names, you could find a wrong
> file that has the same name as a feature (we require files in the load
> path to be uniquely named, but load-history contains all files, not just
> those in the load path).
Like mentioned, we can also check against the `provide' values in each
load-history element we find matching. Shouldn't be a perceptible
performance hit.
> It's an edge case, and my opinion is that a good performance improvement
> is more important than that. But it seems like the 2 biggest performance
> improvements have already been made (the package initialize, and the
> file true name), so I wonder if it's worth it.
200ms per package initialization still seems a lot to me (even if it's
only for certain packages). I also happen to think that the suggested
code is a bit easier to understand, but it's up to you.
next prev parent reply other threads:[~2014-12-18 15:45 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 17:34 bug#19390: 25.0.50; `package-activate' is too slow Dmitry Gutov
[not found] ` <handler.19390.B.14186649209005.ack@debbugs.gnu.org>
2014-12-16 0:41 ` bug#19390: Acknowledgement (25.0.50; `package-activate' is too slow) Dmitry Gutov
2014-12-16 12:32 ` bug#19390: 25.0.50; `package-activate' is too slow Dmitry Gutov
2014-12-16 13:26 ` Artur Malabarba
2014-12-16 13:42 ` Artur Malabarba
2014-12-16 14:31 ` Dmitry Gutov
2014-12-16 21:35 ` Artur Malabarba
2014-12-16 23:16 ` Stefan Monnier
2014-12-16 23:27 ` Dmitry Gutov
2014-12-16 23:55 ` Stefan Monnier
2014-12-17 0:40 ` Artur Malabarba
2014-12-17 1:17 ` Dmitry Gutov
2014-12-17 14:33 ` Artur Malabarba
2014-12-17 2:41 ` Dmitry Gutov
2014-12-17 10:47 ` Artur Malabarba
2014-12-18 0:14 ` Dmitry Gutov
2014-12-18 1:38 ` Stefan Monnier
2014-12-18 2:11 ` Artur Malabarba
2014-12-18 10:37 ` Dmitry Gutov
2014-12-18 14:30 ` Stefan Monnier
2014-12-18 14:47 ` Dmitry Gutov
2014-12-18 15:39 ` Artur Malabarba
2014-12-18 15:47 ` Artur Malabarba
2014-12-18 16:15 ` Dmitry Gutov
2014-12-18 17:50 ` Artur Malabarba
2014-12-18 17:54 ` Dmitry Gutov
2014-12-18 18:40 ` Stefan Monnier
2014-12-18 19:13 ` Artur Malabarba
2014-12-19 4:31 ` Stefan Monnier
2014-12-19 12:08 ` Artur Malabarba
2014-12-18 18:37 ` Stefan Monnier
2014-12-18 15:49 ` Dmitry Gutov
2014-12-18 16:45 ` Dmitry Gutov
2014-12-18 16:14 ` Artur Malabarba
2014-12-18 15:15 ` Artur Malabarba
2014-12-18 15:45 ` Dmitry Gutov [this message]
2014-12-18 17:39 ` Artur Malabarba
2014-12-18 17:52 ` Dmitry Gutov
2014-12-18 19:01 ` Artur Malabarba
2014-12-18 19:49 ` Dmitry Gutov
2014-12-18 18:42 ` Stefan Monnier
2014-12-18 18:45 ` Dmitry Gutov
2014-12-16 16:53 ` Dmitry Gutov
2014-12-16 22:00 ` Artur Malabarba
2014-12-17 1:05 ` Dmitry Gutov
2014-12-16 23:19 ` Stefan Monnier
2014-12-16 23:40 ` Dmitry Gutov
2014-12-16 23:56 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5492F68C.3090700@yandex.ru \
--to=dgutov@yandex.ru \
--cc=19390@debbugs.gnu.org \
--cc=bruce.connor.am@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.