From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master f7572b7: Fix Semantic completion-at-point functions in non-Semantic buffers
Date: Sun, 14 Dec 2014 16:38:27 +0200 [thread overview]
Message-ID: <548DA0E3.6090008@yandex.ru> (raw)
In-Reply-To: <jwviohemhm3.fsf-monnier+emacsdiffs@gnu.org>
On 12/14/2014 04:30 PM, Stefan Monnier wrote:
>> * lisp/cedet/semantic.el (semantic-analyze-completion-at-point-function)
>> (semantic-analyze-notc-completion-at-point-function)
>> (semantic-analyze-nolongprefix-completion-at-point-function): Do
>> nothing if the current buffer is not using Semantic.
>
> Looks like the wrong fix. Don't you think the right fix would be to
> change the add/remove-hooks in semantic-mode so that they are
> buffer-local?
`semantic-mode' is global, so it's easier to have these hooks globally
too. I guess we can move the changing of hooks to
`semantic-new-buffer-fcn', but I don't see its counterpart which would
run when `semantic-mode' is being disabled.
next prev parent reply other threads:[~2014-12-14 14:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141214105944.8359.64300@vcs.savannah.gnu.org>
[not found] ` <E1Y06tt-0002BU-21@vcs.savannah.gnu.org>
2014-12-14 14:30 ` [Emacs-diffs] master f7572b7: Fix Semantic completion-at-point functions in non-Semantic buffers Stefan Monnier
2014-12-14 14:38 ` Dmitry Gutov [this message]
2014-12-14 22:51 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548DA0E3.6090008@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.