From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#19355: 25.0.50; limit the popup window height Date: Sat, 13 Dec 2014 11:21:24 +0100 Message-ID: <548C1324.2070605@gmx.at> References: <87vblhtz5m.fsf@gmail.com> <548AE36C.7060606@gmx.at> <87lhmd6ms4.fsf@gmail.com> <548B2397.7080004@gmx.at> <87h9x0768r.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1418466154 31931 80.91.229.3 (13 Dec 2014 10:22:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 13 Dec 2014 10:22:34 +0000 (UTC) Cc: 19355@debbugs.gnu.org, Juri Linkov To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 13 11:22:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xzjq9-0001mv-JO for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Dec 2014 11:22:21 +0100 Original-Received: from localhost ([::1]:60792 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xzjq9-00073D-2q for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Dec 2014 05:22:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xzjpy-000737-Je for bug-gnu-emacs@gnu.org; Sat, 13 Dec 2014 05:22:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xzjpq-0001TQ-AU for bug-gnu-emacs@gnu.org; Sat, 13 Dec 2014 05:22:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xzjpq-0001TM-6n for bug-gnu-emacs@gnu.org; Sat, 13 Dec 2014 05:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xzjpp-0000c4-PT for bug-gnu-emacs@gnu.org; Sat, 13 Dec 2014 05:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Dec 2014 10:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19355 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19355-submit@debbugs.gnu.org id=B19355.14184661052330 (code B ref 19355); Sat, 13 Dec 2014 10:22:01 +0000 Original-Received: (at 19355) by debbugs.gnu.org; 13 Dec 2014 10:21:45 +0000 Original-Received: from localhost ([127.0.0.1]:44398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzjpZ-0000bV-8g for submit@debbugs.gnu.org; Sat, 13 Dec 2014 05:21:45 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:51968) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XzjpW-0000bI-NO for 19355@debbugs.gnu.org; Sat, 13 Dec 2014 05:21:43 -0500 Original-Received: from [93.82.77.214] ([93.82.77.214]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MK0Np-1Xyusa3p5R-001O97; Sat, 13 Dec 2014 11:21:34 +0100 In-Reply-To: <87h9x0768r.fsf@gmail.com> X-Provags-ID: V03:K0:A6JfBwU32mfA9iILtNxSsyp/I0u/fw2jBM5cVfpR7GAH+EUgfUx zR3R/bZmI0KoLvrAxvzqiLOLNSRDPIz/SlX1fe+eCpq8A8FxBUQPCVx6VTrvPb1Z7V7PW9b Ve+upu/QEGpWkds6GKK9gbX7YFK35O5K6tNBKVfxz6kQz11ZS3HwaoXqOL+tB2bLjiWWTQY RDPu91/rBBtfZ9zxngKrw== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:97284 Archived-At: > Thanks for the clarification. We are on the same page. I don't have > anything specific to add. Just want to point out that > fit-window-to-buffer is probably not the cause for this specific bug. > The contents of the elisp buffer can be a few windowful and I am still > seeing it being squeezed to 4 lines. There's no specific bug here. What you report can be easily considered a user error like choosing a too broad base for completions or failing to appropriately customize the option `window-min-height'. But even if we decide that Emacs made a bad choice when making the *Completions* that large we'd have to decide which heuristics we want to apply instead, like - use `shrink-window-if-larger-than-buffer' instead of `fit-window-to-buffer', - explicitly pass a hardocded maximum height/width argument to `fit-window-to-buffer' (requires some minor changes to `with-displayed-buffer-window') - add some options that allow users to specify the minimum and maximum sizes of _any_ window resized by `fit-window-to-buffer', - tell users that they should customize `display-buffer' appropriately (in this case `with-displayed-buffer-window' would have to do much more work than it does now). In any case, if you want the present behavior to change, you have to express what you want Emacs to do instead ;-) As an aside, I observe that displaying the *Completions* window currently induces three calls to `fit-window-to-buffer' which aren't that cheap, especially when the buffer is large. martin