From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: eggert@cs.ucla.edu, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Patch queue management systems
Date: Tue, 09 Dec 2014 19:17:26 +0200 [thread overview]
Message-ID: <54872EA6.9090405@yandex.ru> (raw)
In-Reply-To: <83iohkwy0p.fsf@gnu.org>
On 12/09/2014 07:09 PM, Eli Zaretskii wrote:
> Magit is not part of Emacs. I think we would like this to be
> integrated into VC.
Right. I meant reimplementing magit-gerrit won't take too much work.
>> Right, but that's only if/when we decide to push all contributions
>> though this system. We could start light, and continue allowing
>> committing directly to the repository, but move the
>> patches-to-be-discussed (which will take up reviewers' time anyway) to
>> the new system.
>
> I'm not sure such a split process makes sense. It will complicate
> procedures and most probably cause some patches fall through the
> cracks.
Why? It's not much different from what happens now.
Consider this: if a patch is posted to the bug tracker or emacs-devel
now, it would go though the new system when it's set up.
Patches that are written by users with commit access and installed
directly will continue to proceed this way.
> I think comments about the form are usually the easiest part of the
> review, and some of that can be automated. Also, some form-related
> issues are actually derived from familiarity with Emacs design and
> implementation. So yes, we could have "junior reviewers" who'd only
> deal with form issues, but that would off-load only a minor portion of
> the work required to do this.
I don't know about that. If the code is written by a senior developer in
the area where they're competent, most of the time only superficial
review is required (unless the author explicitly indicates otherwise).
Then a junior could be enough, too.
next prev parent reply other threads:[~2014-12-09 17:17 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 23:57 bug#19113: Generate a ChangeLog file from commit logs Paul Eggert
2014-11-20 15:51 ` Eli Zaretskii
2014-11-20 17:43 ` Paul Eggert
2014-11-20 17:44 ` Paul Eggert
2014-11-26 5:38 ` Paul Eggert
2014-11-26 6:21 ` Jan D.
2014-11-26 7:50 ` Paul Eggert
2014-11-26 15:12 ` Stefan Monnier
2014-11-26 19:16 ` Paul Eggert
2014-11-26 22:15 ` Stefan Monnier
2014-12-05 8:07 ` Glenn Morris
2014-12-05 8:38 ` Eli Zaretskii
2014-12-05 14:33 ` Ted Zlatanov
2014-12-05 18:49 ` Stefan Monnier
2014-12-05 20:08 ` Ted Zlatanov
2014-12-06 4:59 ` Stefan Monnier
2014-12-06 13:17 ` Ted Zlatanov
2014-12-06 2:27 ` Dmitry Gutov
2014-12-06 5:06 ` Stefan Monnier
2014-12-06 7:26 ` Eli Zaretskii
2014-12-09 13:46 ` Dmitry Gutov
2014-12-06 10:08 ` Patch queue management systems Eli Zaretskii
2014-12-06 13:12 ` Ted Zlatanov
2014-12-08 21:49 ` Thomas Koch
2014-12-08 23:10 ` Lars Magne Ingebrigtsen
2014-12-09 0:00 ` Lars Magne Ingebrigtsen
2014-12-09 0:32 ` Lars Magne Ingebrigtsen
2014-12-09 2:57 ` Stefan Monnier
2014-12-09 3:16 ` Lars Magne Ingebrigtsen
2014-12-09 12:37 ` Dmitry Gutov
2014-12-09 17:20 ` Lars Magne Ingebrigtsen
2014-12-09 20:40 ` Dmitry Gutov
2014-12-09 20:44 ` Lars Magne Ingebrigtsen
2014-12-09 21:32 ` Dmitry Gutov
2014-12-09 21:58 ` Lars Magne Ingebrigtsen
2014-12-09 21:57 ` Lars Magne Ingebrigtsen
2014-12-10 14:35 ` Ted Zlatanov
2014-12-08 22:24 ` Lars Magne Ingebrigtsen
2014-12-08 22:54 ` joakim
2014-12-09 5:31 ` Ivan Andrus
2014-12-09 0:06 ` Thien-Thi Nguyen
2014-12-09 2:54 ` Stefan Monnier
2014-12-09 3:15 ` Lars Magne Ingebrigtsen
2014-12-09 8:13 ` Stephen Leake
2014-12-09 13:03 ` Dmitry Gutov
2014-12-09 17:09 ` Eli Zaretskii
2014-12-09 17:17 ` Dmitry Gutov [this message]
2014-12-09 17:36 ` Eli Zaretskii
2014-12-09 19:31 ` Dmitry Gutov
2014-12-10 14:39 ` Ted Zlatanov
2014-12-11 8:59 ` Steinar Bang
2014-12-11 11:52 ` Ted Zlatanov
2014-12-11 12:38 ` Steinar Bang
2014-12-11 14:31 ` Ted Zlatanov
2014-12-11 14:39 ` David Kastrup
2014-12-11 14:50 ` Ted Zlatanov
2014-12-11 14:55 ` Andreas Schwab
2014-12-11 15:00 ` Ted Zlatanov
2014-12-11 15:26 ` David Kastrup
2014-12-11 15:33 ` Ted Zlatanov
2014-12-11 15:49 ` David Kastrup
2014-12-11 15:19 ` David Kastrup
2014-12-11 18:43 ` Achim Gratz
2014-12-05 15:38 ` bug#19113: Generate a ChangeLog file from commit logs Stefan Monnier
2014-12-06 4:42 ` Paul Eggert
2014-12-06 7:40 ` Eli Zaretskii
2014-12-09 5:14 ` Glenn Morris
2014-12-09 6:42 ` Paul Eggert
2015-01-03 1:37 ` Glenn Morris
2014-11-20 18:00 ` Achim Gratz
2014-11-20 17:25 ` Pádraig Brady
2015-01-12 7:38 ` Paul Eggert
2015-01-15 14:58 ` Stefan Monnier
2015-01-15 21:46 ` Glenn Morris
2015-01-16 1:27 ` Paul Eggert
2015-01-30 16:34 ` Stefan Monnier
2015-01-30 20:14 ` Paul Eggert
2015-01-31 6:33 ` Stefan Monnier
2015-01-31 8:18 ` Paul Eggert
2015-01-31 9:06 ` Andreas Schwab
2015-03-21 2:37 ` Paul Eggert
2015-03-21 8:33 ` Eli Zaretskii
2015-03-21 14:38 ` Stefan Monnier
2015-03-22 23:53 ` Glenn Morris
2015-04-07 7:06 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54872EA6.9090405@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.