From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stephen_leake@stephe-leake.org, emacs-devel@gnu.org
Subject: Re: Your commit 7409a79
Date: Mon, 08 Dec 2014 10:24:33 -0800 [thread overview]
Message-ID: <5485ECE1.8040002@cs.ucla.edu> (raw)
In-Reply-To: <83tx16xhf6.fsf@gnu.org>
On 12/08/2014 07:58 AM, Eli Zaretskii wrote:
>> From: Paul Eggert<eggert@cs.ucla.edu>
>> >
>> >Stephen Leake wrote:
>> >
>> > Now I realize the commit message should have been:
>> >
>> > http:/<archive reference>; no other changes to help the git rename
>> > heuristic
>> >
>> >When a commit merely renames files, wouldn't it be better for the subject line to explain the underlying reason for the change? Something like this, perhaps: "Rename old ChangeLog files to prepare for gitlog-to-changelog." That would be easier to follow than some URL. Any URL could be placed in later lines in the commit message.
> I see no reason for the explanation to be in the summary.
Although explanations don't always need to be in the summary, for
something this small (where the entire commit message can fit into one
line) it's better to do it that way.
The summary in Stephen Leake's draft commit message was
"http://something-or-another; no other changes to help the git rename".
That is less helpful than "Rename ChangeLogs to prep for
gitlog-to-changelog" (see, it fits 50 characters!).
next prev parent reply other threads:[~2014-12-08 18:24 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 8:56 Your commit 7409a79 Eli Zaretskii
2014-12-06 10:22 ` Andreas Schwab
2014-12-06 10:29 ` Eli Zaretskii
2014-12-06 10:32 ` Paul Eggert
2014-12-06 15:29 ` Yuri Khan
2014-12-06 23:01 ` Stefan Monnier
2014-12-06 16:14 ` Tom
2014-12-06 18:54 ` Eli Zaretskii
2014-12-06 22:43 ` Stephen Leake
2014-12-06 22:33 ` Stephen Leake
2014-12-07 3:52 ` Eli Zaretskii
2014-12-07 22:39 ` Stephen Leake
2014-12-08 1:57 ` Paul Eggert
2014-12-08 2:28 ` Stephen J. Turnbull
2014-12-08 15:58 ` Eli Zaretskii
2014-12-08 23:38 ` Stephen Leake
2014-12-08 15:58 ` Eli Zaretskii
2014-12-08 18:24 ` Paul Eggert [this message]
2014-12-08 15:51 ` Eli Zaretskii
2014-12-08 17:32 ` John Yates
2014-12-08 17:57 ` Eli Zaretskii
2014-12-08 18:14 ` Paul Eggert
2014-12-08 18:28 ` Eli Zaretskii
2014-12-08 18:37 ` Eli Zaretskii
2014-12-08 18:54 ` Paul Eggert
2014-12-08 19:00 ` Stefan Monnier
2014-12-08 18:54 ` John Yates
2014-12-08 23:27 ` Stephen Leake
2014-12-09 0:51 ` Thien-Thi Nguyen
2014-12-09 8:08 ` Stephen Leake
2014-12-09 9:36 ` Thien-Thi Nguyen
2014-12-09 16:57 ` Eli Zaretskii
2014-12-10 9:26 ` Stephen Leake
2014-12-10 16:17 ` Eli Zaretskii
2014-12-10 17:04 ` Stephen Leake
2014-12-10 18:02 ` Eli Zaretskii
2014-12-10 19:20 ` Paul Eggert
2014-12-07 5:45 ` Stephen J. Turnbull
2014-12-06 22:59 ` Stefan Monnier
2014-12-07 22:44 ` Stephen Leake
2014-12-07 23:28 ` Stefan Monnier
2014-12-08 9:34 ` Stephen Leake
2014-12-08 10:22 ` Thien-Thi Nguyen
2014-12-08 14:58 ` Stefan Monnier
2014-12-08 23:32 ` Stephen Leake
2014-12-09 11:00 ` Richard Stallman
2014-12-09 11:09 ` David Kastrup
2014-12-10 8:24 ` Richard Stallman
2014-12-10 17:05 ` Stephen Leake
2014-12-10 19:08 ` Stefan Monnier
2014-12-08 15:54 ` Eli Zaretskii
2014-12-08 23:33 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5485ECE1.8040002@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.