From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el. Date: Wed, 03 Dec 2014 11:41:40 -0800 Organization: UCLA Computer Science Department Message-ID: <547F6774.50700@cs.ucla.edu> References: <20141203142859.24393.98673@vcs.savannah.gnu.org> <20141203192721.GE12748@thyrsus.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1417635748 14731 80.91.229.3 (3 Dec 2014 19:42:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2014 19:42:28 +0000 (UTC) Cc: emacs-devel@gnu.org To: esr@thyrsus.com, Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 03 20:42:20 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XwFoZ-0007V4-ND for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2014 20:42:19 +0100 Original-Received: from localhost ([::1]:43083 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFoZ-0000Dl-4N for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2014 14:42:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFoE-0000Df-Uo for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:42:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwFo7-0002yq-Ee for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:41:58 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:39694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFo7-0002yQ-84 for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:41:51 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 9F385A600B2; Wed, 3 Dec 2014 11:41:49 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HIDhHFSNetzI; Wed, 3 Dec 2014 11:41:41 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E0C61A600BD; Wed, 3 Dec 2014 11:41:40 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 In-Reply-To: <20141203192721.GE12748@thyrsus.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178763 Archived-At: On 12/03/2014 11:27 AM, Eric S. Raymond wrote: > You want it even when the ChangeLog part is a trivial > repetition of the summary line? It's not needed for one-liners. For commit e820f16c06a5a6be4bc87910b349c7c3c6eca0f4, for example, your ChangeLog entry was "* files.el (file-tree-walk): Lisp translation of ANSI ftw(3).", and that one-liner should have been the git commit message, too. For longer messages, please use the same text for both the ChangeLog file as for the commit message, except omit the 2nd-blank-line in the former and omit the leading tabs in the latter. For commit b1a765b3a8586cd53c21579982c8fbc0ce534336, in contrast, it would have been better to use the following text (removing indentation) as the commit message: In vc, abolish the dir-status method. * vc.el, all backends: API simplification: Abolish dir-status. It's replaced by dir-status-files. and to use the same text (with indentation, but without the blank line) as the ChangeLog entry. It is a pain to have to have essentially two copies of the same text, one in the ChangeLog file and the other in the commit message, but we haven't yet had strong consensus on fixing this.